Re: [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init()

From	Kevin Hao <haokexin@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init()
Date	2015-08-21 05:20 +0200
Message-ID	<pZL21-880-1@gated-at.bofh.it> (permalink)
References	<pZwZ4-4Ab-17@gated-at.bofh.it> <pZwZ4-4Ab-27@gated-at.bofh.it> <pZCL7-4sw-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Aug 20, 2015 at 08:29:03PM +0200, Peter Zijlstra wrote:
> On Thu, Aug 20, 2015 at 08:14:29PM +0800, Kevin Hao wrote:
> > The jump_label_init() run in a very early stage, even before the
> > sched_init(). So there is no chance for concurrent access of the
> > jump label table.
> 
> It also doesn't hurt to have it. Its better to be consistent and
> conservative with locking unless there is a pressing need.

Yes, it has no real hurt. IMHO it may cause confusion that the function
jump_label_init() may run in two different thread context simultaneously. 
Anyway if you guys don't think so, I can drop this patch.

Thanks,
Kevin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/8] jump_label: no need to acquire the jump_label_mutex in jump_lable_init() Kevin Hao <haokexin@gmail.com> - 2015-08-20 14:20 +0200
  Re: [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex  in jump_lable_init() Peter Zijlstra <peterz@infradead.org> - 2015-08-20 20:30 +0200
    Re: [PATCH 1/8] jump_label: no need to acquire the jump_label_mutex  in jump_lable_init() Kevin Hao <haokexin@gmail.com> - 2015-08-21 05:20 +0200

csiph-web