Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1210807

Re: [RFC] fs/kcore: change copy_to_user to copy_in_user

Show all headers | View raw

On Thu, Aug 20, 2015 at 1:59 AM, yalin wang <yalin.wang2010@gmail.com> wrote:
> -
> -                               n = copy_to_user(buffer, (char *)start, tsz);
> +                               if ((start + tsz < tsz) ||
> +                                               (start + tsz) > TASK_SIZE)
> +                                       return -EFAULT;

This is wrong. You apparently want to have

        if (!access_ok(start, tsz))
                return -EFAULT;

> +                               set_fs(KERNEL_DS);
> +                               n = copy_in_user(buffer, (char *)start, tsz);
> +                               set_fs(USER_DS);

.. and this is actually worse and even less portable than what we have
now, in that it's actively wrong on platforms that may have a user
address and a kernel address with the same value (ie they have
explicitly separate kernel/user address spaces).

Now, that's admittedly unusual, but I think sparc32 actually can do that.

Anyway, I absolutely detest this patch. It replaces one piece of code
that admittedly doesn't work on all architectures because kernel
memory is accessed without testing, with another hack that happens to
work on other architectures and is fragile and prone to be a security
issue.

In other words, I think the end result is _worse_ than the current situation.

You probably want to use "probe_kernel_read()" and do it into a
temporary buffer, and then just do the copy_to_user() from the
temporary buffer. Sure, it's less efficient, but at least it's not
actively wrong and a possible security problem in the long run.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] fs/kcore: change copy_to_user to copy_in_user yalin wang <yalin.wang2010@gmail.com> - 2015-08-20 11:00 +0200
  Re: [RFC] fs/kcore: change copy_to_user to copy_in_user Frans Klaver <fransklaver@gmail.com> - 2015-08-20 12:00 +0200
    Re: [RFC] fs/kcore: change copy_to_user to copy_in_user yalin wang <yalin.wang2010@gmail.com> - 2015-08-20 12:50 +0200
  Re: [RFC] fs/kcore: change copy_to_user to copy_in_user Linus Torvalds <torvalds@linux-foundation.org> - 2015-08-21 02:10 +0200

csiph-web