Groups > linux.kernel > #1209622

Re: [PATCH 2/2] cxl: add set/get private data to context struct

From	Ian Munsie <imunsie@au1.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] cxl: add set/get private data to context struct
Date	2015-08-19 07:20 +0200
Message-ID	<pZ3X4-4C8-3@gated-at.bofh.it> (permalink)
References	<pZ3aG-3oT-7@gated-at.bofh.it> <pZ3aG-3oT-13@gated-at.bofh.it> <pZ3u2-3N2-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Excerpts from Michael Ellerman's message of 2015-08-19 14:49:30 +1000:
> Do we really need the accessors? They don't buy anything I can see over just
> using ctx->priv directly.

The reasoning there is because we don't currently expose the contents of
stuct cxl_context to afu drivers, rather they just treat it as an opaque
type.

We could potentially change this to expose the details, but there's a
lot of junk in there that's just internal details of the cxl driver that
isn't of interest to an afu driver that I'd rather not expose.

We also already have another accessor function (cxl_process_element) in
the api, so it's not out of place.

FWIW I'm not opposed to changing how this api works if it ultimately
makes things better, but I want to wait until the cxlflash superpipe
support is merged so any patches that change the api can change it at
the same time.

Cheers,
-Ian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/2] cxl: Add mechanism for delivering AFU driver specific events "Ian Munsie" <imunsie@au1.ibm.com> - 2015-08-19 06:30 +0200
  [PATCH 2/2] cxl: add set/get private data to context struct "Ian Munsie" <imunsie@au1.ibm.com> - 2015-08-19 06:30 +0200
    Re: [PATCH 2/2] cxl: add set/get private data to context struct Michael Ellerman <mpe@ellerman.id.au> - 2015-08-19 06:50 +0200
      Re: [PATCH 2/2] cxl: add set/get private data to context struct Ian Munsie <imunsie@au1.ibm.com> - 2015-08-19 07:20 +0200
        Re: [PATCH 2/2] cxl: add set/get private data to context struct Michael Ellerman <mpe@ellerman.id.au> - 2015-08-19 07:40 +0200
  Re: [PATCH 1/2] cxl: Add mechanism for delivering AFU driver  specific events Michael Ellerman <mpe@ellerman.id.au> - 2015-08-19 07:40 +0200
    Re: [PATCH 1/2] cxl: Add mechanism for delivering AFU driver specific events Ian Munsie <imunsie@au1.ibm.com> - 2015-08-19 09:10 +0200

csiph-web