Groups > linux.kernel > #1208789

Re: [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic
Date	2015-08-17 20:50 +0200
Message-ID	<pYxDP-7fc-5@gated-at.bofh.it> (permalink)
References	<pYn1L-tt-3@gated-at.bofh.it> <pYn1M-tt-17@gated-at.bofh.it> <pYuZj-3nQ-1@gated-at.bofh.it> <pYxDP-7fc-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/17/2015 12:00 PM, Anirudha Sarangi wrote:
>> From: Peter Hurley [mailto:peter@hurleysoftware.com]
>> On 08/17/2015 03:22 AM, Michal Simek wrote:
>>> From: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
>>>
>>> The existing interrupt handling logic has followins issues.
>>> - Upon a parity error with default configuration, the control
>>>   never comes out of the ISR thereby hanging Linux.
>>> - The error handling logic around framing and parity error are buggy.
>>>   There are chances that the errors will never be captured.
>>> - The existing ISR is just too long.
>>> This patch fixes all these concerns.
>>
>> This patch is unreviewable. Please break this down into multiple patches.
>>
> Thanks. Let me give a shot. It is just breaking the single big ISR that has both Rx and Tx in a single function into smaller ones.
> Not sure how I will create smaller patches, but I will try and get back.

I would start with a refactor patch that splits up the ISR but
makes no other functional changes. Then add the bug fix patches.

Regards,
Peter Hurley

ps - The email signature below is not appropriate for lkml.

> 
> This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd parity Michal Simek <michal.simek@xilinx.com> - 2015-08-17 09:30 +0200
  [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic Michal Simek <michal.simek@xilinx.com> - 2015-08-17 09:30 +0200
    Re: [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 18:00 +0200
      Re: [PATCH 4/4] serial: xuartps: Rewrite the interrupt handling logic Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 20:50 +0200
  Re: [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd  parity Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 17:40 +0200
    Re: [PATCH 1/4] serial: xuartps: Fix termios issue for enabling odd  parity Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 18:30 +0200

csiph-web