Groups > linux.kernel > #1208662

Re: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option

From	Peter Hurley <peter@hurleysoftware.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option
Date	2015-08-17 17:50 +0200
Message-ID	<pYuPE-3cv-29@gated-at.bofh.it> (permalink)
References	<pYn1L-tt-3@gated-at.bofh.it> <pYn1L-tt-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/17/2015 03:22 AM, Michal Simek wrote:
> From: Anirudha Sarangi <anirudha.sarangi@xilinx.com>
> 
> The existing implementation includes overrun errors under IGNPAR
> option. This patch fixes it by including only parity and framing
> error under IGNPAR option.

The convention adopted by Linux serial drivers is to ignore overrun
errors if both IGNPAR and IGNBRK are set.

Regards,
Peter Hurley

> Signed-off-by: Anirudha Sarangi <anirudh@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  drivers/tty/serial/xilinx_uartps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index a3020344ac9d..c4437e8929ff 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -691,7 +691,7 @@ static void cdns_uart_set_termios(struct uart_port *port,
>  
>  	if (termios->c_iflag & IGNPAR)
>  		port->ignore_status_mask |= CDNS_UART_IXR_PARITY |
> -			CDNS_UART_IXR_FRAMING | CDNS_UART_IXR_OVERRUN;
> +					    CDNS_UART_IXR_FRAMING;
>  
>  	/* ignore all characters if CREAD is not set */
>  	if ((termios->c_cflag & CREAD) == 0)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/4] serial: xuartps: Do not handle overrun errors under IGNPAR option Michal Simek <michal.simek@xilinx.com> - 2015-08-17 09:30 +0200
  Re: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under  IGNPAR option Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 17:50 +0200
    Re: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under  IGNPAR option Peter Hurley <peter@hurleysoftware.com> - 2015-08-17 18:20 +0200

csiph-web