Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1208282

Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts

Show all headers | View raw

Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

> On 12 Aug 06:22 PM, Robert Jarzmik wrote:
>
> This fix looks correct. Thanks!
>
> Couple questions:
>
> 1. In which platform are you seeing this bug?
zylonite with a pxa310 (ie. internal stacked NAND).

> 2. Is this a regression? (i.e. should we queue it for -stable?)
No, it's been there for ages I think.

> Also, one might question why we can't just write NDSR right after it's read,
> before we wake the IRQ thread or start DMA. It appears this is
> a requirement of BCH, as per the comment in drain_fifo.
For irq thread that won't make any difference, the irq handler will finish first
and clear the bits anyway. For DMA it's better.

And more generaly speaking, I like it better, to clear it once read.

> It would be nice to put a comment explaining why we clear NDSR only
> before the check to WRCMDREQ. Maybe even copy-pasting something
> from the commit log?
If we move it up to something like that :
	status = nand_readl(info, NDSR);
	nand_writel(info, NDSR, status);
Then the comment is overkill I think.

> I'd like to say "Yay, let's pick it" but I'd like to make sure this is
> tested on all platforms first (unless you've tested it already).
I tested on zylonite (where bug occurs) and cm-x300 (where bug never occurs).

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-12 18:30 +0200
  Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-16 17:40 +0200
    Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-17 00:30 +0200
      Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> - 2015-08-17 21:10 +0200
        Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-17 21:20 +0200
          Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Brian Norris <computersforpeace@gmail.com> - 2015-08-19 02:50 +0200
            Re: [PATCH] mtd: nand: pxa3xx-nand: fix random command timeouts Robert Jarzmik <robert.jarzmik@free.fr> - 2015-08-19 08:30 +0200

csiph-web