Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1207281

Re: [PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot

From Fabio Estevam <festevam@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot
Date 2015-08-14 03:50 +0200
Message-ID <pXci6-4fP-7@gated-at.bofh.it> (permalink)
References <pWXVM-uO-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 13, 2015 at 7:28 AM, Roger Quadros <rogerq@ti.com> wrote:
> The gpio-desc migration done in v4.0 caused a regression
> with legacy boots due to reversed reset logic.
> e.g. omap3-beagle USB host breaks on legacy boot.
>
> Request the reset GPIO with GPIOF_ACTIVE_LOW flag so that
> it matches the driver logic and pin behaviour.
>
> Fixes: e9f2cefb0cdc ("usb: phy: generic: migrate to gpio_desc")
> Cc: <stable@vger.kernel.org> # 4.0+
> Signed-off-by: Roger Quadros <rogerq@ti.com>

The USB on my mx51-babbage board still works fine with this change:

Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot Roger Quadros <rogerq@ti.com> - 2015-08-13 12:30 +0200
  Re: [PATCH] usb: phy: phy-generic: Fix reset behaviour on legacy boot Fabio Estevam <festevam@gmail.com> - 2015-08-14 03:50 +0200

csiph-web