Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1205438

Re: [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver.

Show all headers | View raw

Hi Eric,

Quoting Eric Anholt (2015-07-20 12:33:01)
> +void __init rpi_firmware_init_clock_provider(struct device_node *node)
> +{
> +       /* We delay construction of our struct clks until get time,
> +        * because we need to be able to return -EPROBE_DEFER if the
> +        * firmware driver isn't up yet.  clk core doesn't support
> +        * re-probing on -EPROBE_DEFER, but callers of clk_get can.
> +        */
> +       of_clk_add_provider(node, rpi_firmware_delayed_get_clk, node);
> +}
> +
> +CLK_OF_DECLARE(rpi_firmware_clocks, "raspberrypi,bcm2835-firmware-clocks",
> +              rpi_firmware_init_clock_provider);

Do you require CLK_OF_DECLARE here? Could this be a platform driver
instead?

Regards,
Mike

> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver. Michael Turquette <mturquette@linaro.org> - 2015-08-11 23:20 +0200
  Re: [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver. Eric Anholt <eric@anholt.net> - 2015-08-12 20:10 +0200
    Re: [PATCH v4 2/8] clk: Add a Raspberry Pi-specific clock driver. Michael Turquette <mturquette@baylibre.com> - 2015-08-12 21:10 +0200

csiph-web