Groups > linux.kernel > #1205061

Re: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature
Date	2015-08-11 13:20 +0200
Message-ID	<pWfL4-3t4-11@gated-at.bofh.it> (permalink)
References	<pWfBo-3hD-15@gated-at.bofh.it> <pWfBo-3hD-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 11, 2015 at 04:30:13PM +0530, Srikar Dronamraju wrote:
> Variable sched_numa_balancing is available for both CONFIG_SCHED_DEBUG
> and !CONFIG_SCHED_DEBUG. All code paths now check for
> sched_numa_balancing. Hence remove sched_feat(NUMA).
> 
> Suggested-by: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
>  kernel/sched/core.c     |  6 ------
>  kernel/sched/features.h | 16 ----------------
>  2 files changed, 22 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 7cbdf44..d02570b 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -2063,12 +2063,6 @@ __read_mostly bool sched_numa_balancing;
>  void set_numabalancing_state(bool enabled)
>  {
>  	sched_numa_balancing = enabled;
> -#ifdef CONFIG_SCHED_DEBUG
> -	if (enabled)
> -		sched_feat_set("NUMA");
> -	else
> -		sched_feat_set("NO_NUMA");
> -#endif /* CONFIG_SCHED_DEBUG */
>  }

Could you at least replace sched_numa_balancing with a static_key
thingy?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 0/3] Disable sched_numa_balancing on uma systems Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-08-11 13:10 +0200
  [PATCH v2 3/3] sched/numa: Remove NUMA sched feature Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-08-11 13:10 +0200
    Re: [PATCH v2 3/3] sched/numa: Remove NUMA sched feature Peter Zijlstra <peterz@infradead.org> - 2015-08-11 13:20 +0200
  [PATCH v2 2/3] sched/numa: Disable sched_numa_balancing on uma systems Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-08-11 13:10 +0200
  [PATCH v2 4/4] sched/numa: Convert sched_numa_balancing to a static_branch Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2015-08-11 18:30 +0200

csiph-web