Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1206099

Re: [PATCH 4.2] zram: fix pool names truncation

Show all headers | View raw

On (08/11/15 22:33), Sergey Senozhatsky wrote:
> found this reading the code just now. I do believe we need this
> patch in 4.2 (before 4.3), because the bug breaks new devices
> creation under some specific conditions -- new pool names are
> getting truncated to only 3 digits and, thus,
> debugfs_create_dir() fails.
> 
> The commit message contains more details.
> 

Hello,

I have an alternative fix; a somewhat better one. We actually
don't have to snprintf() there anything. We already have
zram->disk->disk_name constructed exactly same way, so we can
pass it to zram_meta_alloc() instead of device_id.

I'll send out a patch shortly.

	-ss

> 
> Andrew, can you please pick up this patch?
> 
> 
> Sergey Senozhatsky (1):
>   zram: fix max pool limitation
> 
>  drivers/block/zram/zram_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> -- 
> 2.5.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4.2] zram: fix pool names truncation Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-11 15:40 +0200
  [PATCH v2] zram: fix pool name truncation Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-11 17:50 +0200
  [PATCH v3] zram: fix pool name truncation Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-12 15:40 +0200
  Re: [PATCH 4.2] zram: fix pool names truncation Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2015-08-12 15:40 +0200

csiph-web