Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1204490
| From | Noam Camus <noamc@ezchip.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [v2 1/3] serial: 8250_dw: Add support for big-endian MMIO accesses |
| Date | 2015-08-10 21:10 +0200 |
| Message-ID | <pW0Cm-6RM-45@gated-at.bofh.it> (permalink) |
| References | <pOYFk-2Td-9@gated-at.bofh.it> <pTxEt-1tJ-3@gated-at.bofh.it> <pTxEt-1tJ-5@gated-at.bofh.it> <pTxEu-1tJ-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Greg KH [mailto:greg@kroah.com] Sent: Tuesday, August 04, 2015 2:43 AM > > - writel(value, p->membase + (offset << p->regshift)); > Why drop this write? This was not dropped, it is now part of dw8250_serial_out32(). Now it is called before updating last_mcr. > > - writel(value, p->membase + (UART_LCR << p->regshift)); > > + if (p->iotype == UPIO_MEM32BE) > > + iowrite32be(value, > > + p->membase + (UART_LCR << p->regshift)); > > + else > > + writel(value, > > + p->membase + (UART_LCR << p->regshift)); > Shouldn't this be hidden behind some other type of accessor? Why is this one writel() "special"? I will add inner level accessors into "struct dw8250_data" for in32/out32. new accessors will be used in few places in this driver that still uses writel/readl without considering iotype. Noam-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
RE: [v2 1/3] serial: 8250_dw: Add support for big-endian MMIO accesses Noam Camus <noamc@ezchip.com> - 2015-08-10 21:10 +0200
csiph-web