Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1202876
| From | Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers |
| Date | 2015-08-07 18:30 +0200 |
| Message-ID | <pUSGS-4Rc-5@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <pUQc1-152-13@gated-at.bofh.it> <pUQlI-1gJ-35@gated-at.bofh.it> <pURrs-35x-11@gated-at.bofh.it> <pURUu-3H0-15@gated-at.bofh.it> <pUSnw-4uf-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/07/2015 06:07 PM, Peter Hurley wrote:
>> If we look at what 8250-dma.c is doing:
>>
>> if (dma->rx_running) {
>> dmaengine_pause(dma->rxchan);
>>
>> It's 8250-dma.c which is silently _ignoring_ the return code, failing
>> to check that the operation it requested worked. Maybe this should be
>> WARN_ON(dmaengine_pause(dma->rxchan)) or at least it should print a
>> message?
>
> Thanks for the suggestion; I'll hold on to that and push it after we add
> the 8250 omap dma pause in mainline.
I have a patch ready with WARN_ON_ONCE() for 8250-omap and 8250-dma.
This warning would trigger on am335x/edma until v4.2-rc1 and omap-dma
based version is open. I could post it if you want me to.
Besides that those two, there are four other drivers ignoring the
return code dmaengine_pause().
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 10:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-08-07 11:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 12:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Ujfalusi <peter.ujfalusi@ti.com> - 2015-08-07 13:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 14:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 15:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 15:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 16:00 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-07 17:10 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 17:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 17:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 18:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-07 19:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 19:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-07 18:10 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 18:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 18:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 18:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-07 20:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 20:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-08 03:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-08 11:10 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 13:00 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 14:40 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 15:20 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-08-07 15:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Peter Hurley <peter@hurleysoftware.com> - 2015-08-07 16:50 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2015-08-07 15:30 +0200
Re: [PATCH] dma: omap-dma: add support for pause of non-cyclic transfers Greg KH <greg@kroah.com> - 2015-08-07 20:00 +0200
csiph-web