Groups > linux.kernel > #1200512

Re: [PATCH] virtio-input: reset device during remove

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] virtio-input: reset device during remove
Date	2015-08-05 10:20 +0200
Message-ID	<pU25z-411-1@gated-at.bofh.it> (permalink)
References	<pU1jc-2Rg-11@gated-at.bofh.it> <pU1Me-3p8-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/05/2015 03:56 PM, Michael S. Tsirkin wrote:
> On Wed, Aug 05, 2015 at 03:20:18PM +0800, Jason Wang wrote:
>> > Spec requires a device reset during cleanup, so do it and avoid warn
>> > in virtio core.
>> > 
>> > Signed-off-by: Jason Wang <jasowang@redhat.com>
> OK but now that I look at this driver, that's not enough.
>
> Need to also detach and free unused buffers, otherwise
> we leak memory in evt and sts queues.

Probably only sts. For evt queue, all buffer it used was an array
embedded in virtio_input structure (vi->evts[])
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] virtio-input: reset device during remove Jason Wang <jasowang@redhat.com> - 2015-08-05 09:30 +0200
  Re: [PATCH] virtio-input: reset device during remove "Michael S. Tsirkin" <mst@redhat.com> - 2015-08-05 10:00 +0200
    Re: [PATCH] virtio-input: reset device during remove Jason Wang <jasowang@redhat.com> - 2015-08-05 10:20 +0200

csiph-web