Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1198790
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl |
| Date | 2015-08-03 14:20 +0200 |
| Message-ID | <pTmSK-2M2-13@gated-at.bofh.it> (permalink) |
| References | <pTmg1-1ME-1@gated-at.bofh.it> <pTmg2-1ME-15@gated-at.bofh.it> <pTmpI-1Yc-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote: > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote: > > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote: > > > From: Yash Shah <yshah1@visteon.com> > > > > > > Fixed code indentation warning as detected by checkpatch.pl. > > > > > > Signed-off-by: Yash Shah <yshah1@visteon.com> > > > > Defines aren't allowed in .c files anyway. > > The kernel source tree disagrees with you > > $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l > 175830 Duh. Sorry. I meant ifdefs. I'm sure you can find lots of examples of those too, but this code would be cleaner without the ifdefs. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl "Shah, Yash (Y.)" <yshah1@visteon.com> - 2015-08-03 13:40 +0200
Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-03 13:40 +0200
Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Joe Perches <joe@perches.com> - 2015-08-03 13:50 +0200
Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Dan Carpenter <dan.carpenter@oracle.com> - 2015-08-03 14:20 +0200
Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Joe Perches <joe@perches.com> - 2015-08-03 14:20 +0200
csiph-web