Groups > linux.kernel > #1199925

Re: [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug()

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] watchdog: use suspend/resume interface in fixup_ht_bug()
Date	2015-08-04 16:50 +0200
Message-ID	<pTLHs-552-29@gated-at.bofh.it> (permalink)
References	<pSEoF-4YJ-3@gated-at.bofh.it> <pSEoF-4YJ-1@gated-at.bofh.it> <pTKBH-3xf-9@gated-at.bofh.it> <pTLo6-4If-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 04-08-15 10:27:50, Don Zickus wrote:
> On Tue, Aug 04, 2015 at 03:31:30PM +0200, Michal Hocko wrote:
> > On Sat 01-08-15 14:49:25, Ulrich Obergfell wrote:
> > [...]
> > > @@ -3368,7 +3368,10 @@ static __init int fixup_ht_bug(void)
> > >  		return 0;
> > >  	}
> > >  
> > > -	watchdog_nmi_disable_all();
> > > +	if (watchdog_suspend() != 0) {
> > > +		pr_info("failed to disable PMU erratum BJ122, BV98, HSD29 workaround\n");
> > > +		return 0;
> > > +	}
> > 
> > Is this really worth reporting to the log? What is an admin supposed to
> > do about it?
> 
> I think it was more for developers to aid in debugging a strange behaviour
> of the performance counters.

pr_debug then?

> > <looking into the code>
> > Ok, so kthread_park fails only when the kernel thread has already
> > exited. Can this ever happen during this call path?
> 
> It might be overkill, but it is just a harmless informational failure
> message.

Maybe we have way too many of those harmless informational failure
admins scratch their heads about...
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 4/4] watchdog: use suspend/resume interface in  fixup_ht_bug() Michal Hocko <mhocko@kernel.org> - 2015-08-04 15:40 +0200
  Re: [PATCH 4/4] watchdog: use suspend/resume interface in  fixup_ht_bug() Don Zickus <dzickus@redhat.com> - 2015-08-04 16:30 +0200
    Re: [PATCH 4/4] watchdog: use suspend/resume interface in  fixup_ht_bug() Michal Hocko <mhocko@kernel.org> - 2015-08-04 16:50 +0200
    Re: [PATCH 4/4] watchdog: use suspend/resume interface in  fixup_ht_bug() Ulrich Obergfell <uobergfe@redhat.com> - 2015-08-04 17:10 +0200

csiph-web