Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1199777

[PATCH] fbcon: unconditionally initialize cursor blink interval

From Scot Doyle <lkml14@scotdoyle.com>
Newsgroups linux.kernel
Subject [PATCH] fbcon: unconditionally initialize cursor blink interval
Date 2015-08-04 14:40 +0200
Message-ID <pTJFD-2bp-7@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


A sun7i-a20-olinuxino-micro fails to boot when kernel parameter
vt.global_cursor_default=0. The value is copied to vc->vc_deccm
causing the initialization of ops->cur_blink_jiffies to be skipped.
Unconditionally initialize it.

Reported-and-tested-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Scot Doyle <lkml14@scotdoyle.com>
---
 drivers/video/console/fbcon.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
index 658c34b..1aaf893 100644
--- a/drivers/video/console/fbcon.c
+++ b/drivers/video/console/fbcon.c
@@ -1306,10 +1306,11 @@ static void fbcon_cursor(struct vc_data *vc, int mode)
 	int y;
  	int c = scr_readw((u16 *) vc->vc_pos);
 
+	ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);
+
 	if (fbcon_is_inactive(vc, info) || vc->vc_deccm != 1)
 		return;
 
-	ops->cur_blink_jiffies = msecs_to_jiffies(vc->vc_cur_blink_ms);
 	if (vc->vc_cursor_type & 0x10)
 		fbcon_del_cursor_timer(info);
 	else
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] fbcon: unconditionally initialize cursor blink interval Scot Doyle <lkml14@scotdoyle.com> - 2015-08-04 14:40 +0200
  Re: [PATCH] fbcon: unconditionally initialize cursor blink interval Pavel Machek <pavel@ucw.cz> - 2015-08-04 22:40 +0200
    Re: [PATCH] fbcon: unconditionally initialize cursor blink  interval Scot Doyle <lkml14@scotdoyle.com> - 2015-08-10 16:10 +0200
      Re: [PATCH] fbcon: unconditionally initialize cursor blink interval Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-08-10 16:30 +0200

csiph-web