Groups > linux.debian.bugs.dist > #668868

Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools

From	Roger Shimizu <rogershimizu@gmail.com>
Newsgroups	linux.debian.bugs.dist, linux.debian.kernel
Subject	Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools
Date	2015-08-02 12:20 +0200
Message-ID	<pSYx4-Um-3@gated-at.bofh.it> (permalink)
References	<pQRT4-4QW-13@gated-at.bofh.it> <pRfVn-6b1-7@gated-at.bofh.it> <pRiTg-1Zj-19@gated-at.bofh.it> <pRwjw-4xK-3@gated-at.bofh.it> <pSn4u-5dR-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Cross-posted to 2 groups.

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Dear Ian,

Thanks for your feedback!

After reading your comment, I reviewed the whole procedure of loading
netconsole module during initramfs-tools booting, previously and after
my patch, I start to consider that original "modprobe netconsole
netconsole=$param" line in init file is merely a dirty hack. The real
fix is to load the netconsole module with param inside load_modules()
routine.

So I created v3 patchset, which looks more clean to me.
Of course patchset v2 & v3 both works well as I tested. So I let the
package maintainer to choose which is better to merge.


Dear Maintainer,

Enclosed is the updated patchset v3.

Changelog:
v1 => v2: for 0002 patch: commit log change
v2 => v3: for 0001 patch: change loading netconsole module timing from
separately in init script to load_modules() routine
v2 pros: limit the affected range only when netconsole is set; cons:
netconsole module would be load twice, so seems a dirty hack
v3 pros: clean code; cons: add a condition judging on each module
loading (overhead?)

Both v2 and v3 are fine to me.
Please simply pick one when to merge. Thank you!

Cheers,
Roger

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools Roger Shimizu <rogershimizu@gmail.com> - 2015-07-27 16:50 +0200
  Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools Roger Shimizu <rogershimizu@gmail.com> - 2015-07-29 12:00 +0200
    Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools Roger Shimizu <rogershimizu@gmail.com> - 2015-07-31 19:10 +0200
    Bug#793786: initramfs-tools: fix the broken netconsole feature in initramfs-tools Roger Shimizu <rogershimizu@gmail.com> - 2015-08-02 12:20 +0200

csiph-web