Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1195755

Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU

Show all headers | View raw

On 30/07/2015 05:55, Steve Rutherford wrote:
> >  static void vcpu_scan_ioapic(struct kvm_vcpu *vcpu)
> >  {
> > -	u64 eoi_exit_bitmap[4];
> > -
> >  	if (!kvm_apic_hw_enabled(vcpu->arch.apic))
> >  		return;
> >  
> > -	memset(eoi_exit_bitmap, 0, 32);
> > +	memset(vcpu->arch.eoi_exit_bitmap, 0, 256 / 8);
> >  
> > -	kvm_ioapic_scan_entry(vcpu, eoi_exit_bitmap);
> > -	kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap);
> > +	kvm_ioapic_scan_entry(vcpu, vcpu->arch.eoi_exit_bitmap);
> Nit: Does scan entry still need to carry around the pointer to the bitmap?

IIRC I was copying what you did in your patch, but I also think it's
better this way.  The IOAPIC has no business in the vcpu structure's
fields; it only needs it in order to pass vcpu to kvm_apic_match_dest.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU Paolo Bonzini <pbonzini@redhat.com> - 2015-07-29 15:40 +0200
  Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU Steve Rutherford <srutherford@google.com> - 2015-07-30 06:00 +0200
    Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU Paolo Bonzini <pbonzini@redhat.com> - 2015-07-30 09:20 +0200

csiph-web