Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1193821

Re: [PATCH] Drivers: isdn: Drop unnecessary continue

From Julia Lawall <julia.lawall@lip6.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] Drivers: isdn: Drop unnecessary continue
Date 2015-07-28 09:30 +0200
Message-ID <pR7uO-2kS-9@gated-at.bofh.it> (permalink)
References <pR7l8-29J-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw



On Tue, 28 Jul 2015, Shraddha Barke wrote:

> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
>   ...
>   if (...) {
>     ...
> -   continue;
>   }
> }
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
>  drivers/isdn/hardware/mISDN/hfcsusb.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..34e4b6c 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1923,7 +1923,6 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
>  		    (le16_to_cpu(dev->descriptor.idProduct)
>  		     == hfcsusb_idtab[i].idProduct)) {
>  			vend_idx = i;
> -			continue;

Now there is only one statement in the branch, so the {} should go as
well.

julia

>  		}
>  	}
>
> --
> 2.1.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] Drivers: isdn: Drop unnecessary continue Shraddha Barke <shraddha.6596@gmail.com> - 2015-07-28 09:20 +0200
  Re: [PATCH] Drivers: isdn: Drop unnecessary continue Julia Lawall <julia.lawall@lip6.fr> - 2015-07-28 09:30 +0200

csiph-web