Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1190895

Re: [RFC] arm64:use set_fixmap_offset to make it more clear

Show all headers | View raw

On Thu, Jul 23, 2015 at 07:45:53PM +0800, yalin wang wrote:
> A little change to patch_map() function,
> use set_fixmap_offset() to make code more clear.
> 
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
> ---
>  arch/arm64/kernel/insn.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/kernel/insn.c b/arch/arm64/kernel/insn.c
> index dd9671c..7dafd5a 100644
> --- a/arch/arm64/kernel/insn.c
> +++ b/arch/arm64/kernel/insn.c
> @@ -101,9 +101,8 @@ static void __kprobes *patch_map(void *addr, int fixmap)
>  		return addr;
>  
>  	BUG_ON(!page);
> -	set_fixmap(fixmap, page_to_phys(page));
> -
> -	return (void *) (__fix_to_virt(fixmap) + (uintaddr & ~PAGE_MASK));
> +	return (void *)set_fixmap_offset(fixmap, page_to_phys(page) +
> +			(addr & ~PAGE_MASK));

It looks fine. Do you get any compiler warning for the automatic pointer
to long conversion? You may want to add some explicit casts, otherwise:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC] arm64:use set_fixmap_offset to make it more clear Catalin Marinas <catalin.marinas@arm.com> - 2015-07-23 15:10 +0200
  Re: [RFC] arm64:use set_fixmap_offset to make it more clear Mark Rutland <mark.rutland@arm.com> - 2015-07-24 12:00 +0200
    Re: [RFC] arm64:use set_fixmap_offset to make it more clear Mark Rutland <mark.rutland@arm.com> - 2015-07-24 12:10 +0200
      Re: [RFC] arm64:use set_fixmap_offset to make it more clear yalin wang <yalin.wang2010@gmail.com> - 2015-07-24 14:00 +0200

csiph-web