Re: [PATCH v3 2/2] ARM: dts: vf-colibri: Add property for minimum sample time

From	Stefan Agner <stefan@agner.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] ARM: dts: vf-colibri: Add property for minimum sample time
Date	2015-07-15 15:10 +0200
Message-ID	<pMuBH-8op-13@gated-at.bofh.it> (permalink)
References	<pM8Uy-2QN-3@gated-at.bofh.it> <pM8Uy-2QN-11@gated-at.bofh.it> <pMk9j-1ri-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2015-07-15 03:57, Shawn Guo wrote:
> On Tue, Jul 14, 2015 at 07:23:23PM +0530, Sanchayan Maity wrote:
>> Add a device tree property which allows to specify the minimum sample
>> time which can be used to calculate the actual ADC cycles required
>> depending on the hardware.
>>
>> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
>> ---
>>  arch/arm/boot/dts/vf-colibri.dtsi | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/vf-colibri.dtsi b/arch/arm/boot/dts/vf-colibri.dtsi
>> index ab10d2e..59f5deb 100644
>> --- a/arch/arm/boot/dts/vf-colibri.dtsi
>> +++ b/arch/arm/boot/dts/vf-colibri.dtsi
>> @@ -16,10 +16,12 @@
>>  };
>>
>>  &adc0 {
>> +	min-sample-time = <1000>;
>>  	status = "okay";
>>  };
>>
>>  &adc1 {
>> +	min-sample-time = <1000>;
> 
> Since this is the default value anyway, we can just save the patch,
> right?

I thought it would be nice to be explicit here and define this value
which we verified internally.

On the other hand, we did not derived the minimum value from the DS
(using the capacity/resistance of the actual analog source connected) to
maximize the sampling frequency, hence I'm also ok with not explicitly
defining a value.

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 2/2] ARM: dts: vf-colibri: Add property for minimum  sample time Shawn Guo <shawnguo@kernel.org> - 2015-07-15 04:00 +0200
  Re: [PATCH v3 2/2] ARM: dts: vf-colibri: Add property for minimum  sample time Stefan Agner <stefan@agner.ch> - 2015-07-15 15:10 +0200

csiph-web