Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1186196

[RFC] workqueue: avoiding unbounded wq on isolated CPUs by default

From Daniel Bristot de Oliveira <bristot@redhat.com>
Newsgroups linux.kernel
Subject [RFC] workqueue: avoiding unbounded wq on isolated CPUs by default
Date 2015-07-16 21:20 +0200
Message-ID <pMWRk-7rm-9@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


By default, unbounded workqueues run on all CPUs, which includes
isolated CPUs. This patch avoids unbounded workqueues running on
isolated CPUs by default, keeping the current behavior when no
CPUs were isolated.

Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
---
 kernel/workqueue.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 4c4f061..14d17f4 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -5217,7 +5217,10 @@ static int __init init_workqueues(void)
 	WARN_ON(__alignof__(struct pool_workqueue) < __alignof__(long long));
 
 	BUG_ON(!alloc_cpumask_var(&wq_unbound_cpumask, GFP_KERNEL));
-	cpumask_copy(wq_unbound_cpumask, cpu_possible_mask);
+
+	/* by default, run unbound wq on non-isolated CPUs */
+	cpumask_andnot(wq_unbound_cpumask, cpu_possible_mask,
+		       cpu_isolated_map);
 
 	pwq_cache = KMEM_CACHE(pool_workqueue, SLAB_PANIC);
 
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[RFC] workqueue: avoiding unbounded wq on isolated CPUs by default Daniel Bristot de Oliveira <bristot@redhat.com> - 2015-07-16 21:20 +0200
  Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by  default Tejun Heo <tj@kernel.org> - 2015-07-16 21:30 +0200
    Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by  default Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-07-17 06:30 +0200
      Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by  default Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-07-19 10:10 +0200
        Re: [RFC] workqueue: avoiding unbounded wq on isolated CPUs by  default Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-07-19 14:20 +0200
        [patch] workqueue: schedule WORK_CPU_UNBOUND work on  wq_unbound_cpumask CPUs Mike Galbraith <umgwanakikbuti@gmail.com> - 2015-07-22 07:30 +0200
          [PATCH] workqueue: avoiding unbounded wq on isolated CPUs by default Daniel Bristot de Oliveira <bristot@redhat.com> - 2015-07-22 14:50 +0200
          Re: [patch] workqueue: schedule WORK_CPU_UNBOUND work on  wq_unbound_cpumask CPUs Tejun Heo <tj@kernel.org> - 2015-07-22 16:20 +0200

csiph-web