Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1186055

Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running on 64KB granularity

Show all headers | View raw

Hi Stefano,

On 16/07/2015 16:47, Stefano Stabellini wrote:
  >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
>> index 3679293..0a1f903 100644
>> --- a/drivers/xen/grant-table.c
>> +++ b/drivers/xen/grant-table.c
>
> The arm part is fine, but aren't you missing the change to RPP and SPP?

SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 
as it was unused.

For RPP, it's used internally so there is no need to switch to 
XEN_PAGE_SIZE. Otherwise we will waste 60KB for each internal page 
allocated (see gnttab_init).

Regards,

-- 
Julien Grall
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 14/20] xen/grant-table: Make it running on 64KB  granularity Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-07-16 17:50 +0200
  Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running  on 64KB granularity Julien Grall <julien.grall@citrix.com> - 2015-07-16 18:30 +0200
    Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running  on 64KB granularity Stefano Stabellini <stefano.stabellini@eu.citrix.com> - 2015-07-17 15:40 +0200

csiph-web