Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if not set

From	Grygorii Strashko <grygorii.strashko@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if not set
Date	2015-07-16 14:00 +0200
Message-ID	<pMPZx-5LR-11@gated-at.bofh.it> (permalink)
References	<pFji2-77d-1@gated-at.bofh.it> <pFji2-77d-21@gated-at.bofh.it> <pMPwt-5cU-1@gated-at.bofh.it> <pMPww-5cU-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 07/16/2015 02:25 PM, Linus Walleij wrote:
> On Thu, Jul 16, 2015 at 1:22 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Thu, Jun 25, 2015 at 7:30 PM, Grygorii Strashko
>> <grygorii.strashko@ti.com> wrote:
>>
>>> Assign GPIO chip owner field to chip->dev->driver->owner if it was not
>>> configured by GPIO driver.
>>>
>>> Cc: Johan Hovold <johan@kernel.org>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>
>> Patch applied with Alex' review tag.
>>
>>>   There is also one positive additional side effect:
>>>   lines like below can be removed from a lot of GPIO
>>>   drivers
>>>          rdc321x_gpio_dev->chip.owner = THIS_MODULE;
>>
>> Yes let's do this :)
>
> Or actually, I have had some second thought to why gpio_chip
> is duplicating struct members from struct device at all.
>
> Why should it even have "owner" and "of_node"?
>
> Should we not just rewrite this code to follow the struct device *dev
> pointer in gpio_chip and use "owner" and "of_node" from there?
>

Seems not all drivers implemented using Dev/Driver approach,
so they don't have dev at all ;)

gpio-samsung.c for example (non-DT driver).


-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if  not set Linus Walleij <linus.walleij@linaro.org> - 2015-07-16 13:30 +0200
  Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if  not set Linus Walleij <linus.walleij@linaro.org> - 2015-07-16 13:30 +0200
    Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner  if not set Grygorii Strashko <grygorii.strashko@ti.com> - 2015-07-16 14:00 +0200

csiph-web