Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1185792

[PATCH] blk-mq: set default timeout as 30 seconds

From Ming Lei <ming.lei@canonical.com>
Newsgroups linux.kernel
Subject [PATCH] blk-mq: set default timeout as 30 seconds
Date 2015-07-16 14:00 +0200
Message-ID <pMPZw-5LR-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


It is reasonable to set default timeout of request as
30 seconds instead of 30000 ticks, which may be 300 seconds
if HZ is 100, for example, some arm64 based systems may choose
100 HZ.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
---
 block/blk-mq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index f537796..7d842db 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1998,7 +1998,7 @@ struct request_queue *blk_mq_init_allocated_queue(struct blk_mq_tag_set *set,
 		goto err_hctxs;
 
 	setup_timer(&q->timeout, blk_mq_rq_timer, (unsigned long) q);
-	blk_queue_rq_timeout(q, set->timeout ? set->timeout : 30000);
+	blk_queue_rq_timeout(q, set->timeout ? set->timeout : 30 * HZ);
 
 	q->nr_queues = nr_cpu_ids;
 	q->nr_hw_queues = set->nr_hw_queues;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH] blk-mq: set default timeout as 30 seconds Ming Lei <ming.lei@canonical.com> - 2015-07-16 14:00 +0200
  Re: [PATCH] blk-mq: set default timeout as 30 seconds Jens Axboe <axboe@fb.com> - 2015-07-16 16:40 +0200

csiph-web