Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled

From	Julius Werner <jwerner@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in suspend if wakeup is enabled
Date	2015-07-08 02:10 +0200
Message-ID	<pJL61-42D-1@gated-at.bofh.it> (permalink)
References	<pJjW9-3Rs-9@gated-at.bofh.it> <pJC2K-6Jr-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Doug, how would you feel about reworking the patch that exports
> usb_wakeup_enabled_descendants()?  Instead of doing it that way, create
> and export a new subroutine in hcd.c called
> usb_hcd_wakeup_not_needed(), or something similar.

We have a use case with another host controller (Tegra, which I think
is still in the process of being upstreamed) where we are able to
power down PHYs (and thus reduce power consumption) per port. I think
we should prefer the more flexible 'number of wake devices in subtree'
interface to be able to support cases like that. (And for the simple
case, 'if (usb_hcd_wakeup_not_needed(hcd))' and 'if
(!usb_wakeup_enabled_descendants(hcd->self.root_hub))' look pretty
similar anyway.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [REPOST PATCH 3/3] USB: dwc2: Don't turn off the usbphy in  suspend if wakeup is enabled Julius Werner <jwerner@chromium.org> - 2015-07-08 02:10 +0200

csiph-web