Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale

From	Tomasz Figa <tfiga@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale
Date	2015-07-03 16:40 +0200
Message-ID	<pIaid-1dJ-17@gated-at.bofh.it> (permalink)
References	(1 earlier) <pFyK6-44X-11@gated-at.bofh.it> <pI3Ts-5Gf-23@gated-at.bofh.it> <pI5ix-6Fa-13@gated-at.bofh.it> <pI64V-7ct-1@gated-at.bofh.it> <pI6oi-7jr-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jul 3, 2015 at 7:22 PM, Mark yao <mark.yao@rock-chips.com> wrote:
> On 2015年07月03日 17:58, Tomasz Figa wrote:
>>>>
>>>> >>Aren't the scl_modes for CbCr planes always the same as for Y plane?
>>>
>>> >
>>> >
>>> >No, such as src(1920 x 1080) -> dst(1280x800), yuv format is NV12.
>>> >so Y plane horizontal and vertical is scale down.
>>> >
>>> >but src_w = 1920 / 2 = 960 < 1280
>>> >       src_h = 1080 / 2 = 540 < 800.
>>> >
>>> >So Cbcr horizontal and vertical is scale up.
>>
>> Sorry, I don't follow.
>>
>> If we scale down Y plane in NV12 from 1920x1080 to 1280x800, then
>> original CbCr plane will be 960x540 and destination CbCr plane will be
>> 640x400 (because CbCr plane of NV12 is subsampled 2x2, which is half
>> the width and half the height of Y plane), so both planes are being
>> scaled down.
>>
> destination CbCr plane is 1280x800, destination can't be subsample.

Ah, I see, so internally it's always scalling to destination plane
size. This means that calculation for both Y and CbCr must be done
indeed, but even then you could use helper functions for that, since
they differ only in parameters.

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Mark yao <mark.yao@rock-chips.com> - 2015-07-03 11:20 +0200
  Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Tomasz Figa <tfiga@chromium.org> - 2015-07-03 12:10 +0200
    Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-07-03 12:20 +0200
    Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Mark yao <mark.yao@rock-chips.com> - 2015-07-03 12:30 +0200
      Re: [PATCH v2 3/5] drm/rockchip: vop: support plane scale Tomasz Figa <tfiga@chromium.org> - 2015-07-03 16:40 +0200

csiph-web