Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1176433

Re: Kconfig: '+config' valid syntax?

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On 07/03/2015 10:59, Paul Bolle wrote:
> On vr, 2015-07-03 at 09:33 +0200, Andreas Ruprecht wrote:
>> I tested the behaviour on yesterday's linux-next, but the commit
>> mentioned above will only complain for invalid characters inside the
>> PARAM case and not for COMMANDs. So, as an example, if you write
>> something like
>>
>> config ACPI_REV_OVERRIDE_POSSIBLE
>> 	depends on X86 +
>> [...]
>>
>> Kconfig will complain about the '+'. This, however, does not apply for
>> top-level statements like 'config', 'menuconfig', and so on.
> 
> Which might explain why this silly mistake went unnoticed. (And, as I
> think you implied, it doesn't help that the empty rule we're hitting
> here is not commented.)
> 
> So the naive solution seems to be to also add the warning to COMMAND's
> rule for '.'. A quick test suggest that would work. Am I missing some
> obvious downside with that solution?

Well, as I mentioned earlier, with a patch similar to the one below this
warning is also generated three times for every '---' before 'help'.
This results in a giant pile of warnings:

ruprecht@box:linux-next$ rm -f scripts/kconfig/*_shipped &&
REGENERATE_PARSERS=1 make allyesconfig 2>&1 | wc -l
7419

The output looks like this:
scripts/kconfig/conf  --allyesconfig Kconfig
arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
arch/x86/Kconfig:4:warning: ignoring unsupported character '-'
init/Kconfig:222:warning: ignoring unsupported character '-'
init/Kconfig:222:warning: ignoring unsupported character '-'
init/Kconfig:222:warning: ignoring unsupported character '-'
init/Kconfig:244:warning: ignoring unsupported character '-'
init/Kconfig:244:warning: ignoring unsupported character '-'
init/Kconfig:244:warning: ignoring unsupported character '-'
[...]

So we would need to add special treatment for '-' also in the command
case, right? But that doesn't look appealing to me, more like a dirty,
dirty hack around the actual problem...

Regards,

Andreas

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: Kconfig: '+config' valid syntax? Paul Bolle <pebolle@tiscali.nl> - 2015-07-02 11:10 +0200
  Re: Kconfig: '+config' valid syntax? Paul Bolle <pebolle@tiscali.nl> - 2015-07-02 11:30 +0200
  Re: Kconfig: '+config' valid syntax? Andreas Ruprecht <andreas.ruprecht@fau.de> - 2015-07-03 11:30 +0200
    Re: Kconfig: '+config' valid syntax? Ulf Magnusson <ulfalizer.lkml@gmail.com> - 2015-07-03 12:50 +0200
      Re: Kconfig: '+config' valid syntax? Valentin Rothberg <valentinrothberg@gmail.com> - 2015-07-03 13:00 +0200
        Re: Kconfig: '+config' valid syntax? Stefan Hengelein <stefan.hengelein@fau.de> - 2015-07-03 13:00 +0200
      Re: Kconfig: '+config' valid syntax? Paul Bolle <pebolle@tiscali.nl> - 2015-07-03 13:10 +0200
    Re: Kconfig: '+config' valid syntax? Paul Bolle <pebolle@tiscali.nl> - 2015-07-03 13:00 +0200

csiph-web