Re: [PATCH 1/2] arm: devtree: Save atags if are in DT atags field

From	Tony Lindgren <tony@atomide.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] arm: devtree: Save atags if are in DT atags field
Date	2015-06-25 07:10 +0200
Message-ID	<pF7Ae-7fK-9@gated-at.bofh.it> (permalink)
References	<pn3bH-5y8-7@gated-at.bofh.it> <pqtW2-1jE-15@gated-at.bofh.it> <pqtW2-1jE-23@gated-at.bofh.it> <pqufo-1Wg-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Arnd Bergmann <arnd@arndb.de> [150515 13:11]:
> On Friday 15 May 2015 21:50:06 Pali Rohár wrote:
> > @@ -256,5 +257,10 @@ const struct machine_desc * __init setup_machine_fdt(unsigned int dt_phys)
> >                         system_rev = 0;
> >         }
> >  
> > +       /* Save atags */
> > +       prop = of_get_flat_dt_prop(dt_root, "atags", NULL);
> > +       if (prop)
> > +               save_atags((void *)prop);
> > +
> >         return mdesc;
> > 
> 
> How about checking whether this is actually running on the one board
> that needs it first?
> 
> I'd rather not introduce something that may end up being considered
> an ABI on other machines.

It seems having this within CONFIG_ARM_ATAG_DTB_COMPAT should be
enough here.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 1/2] arm: devtree: Save atags if are in DT atags field Tony Lindgren <tony@atomide.com> - 2015-06-25 07:10 +0200

csiph-web