Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()

From	Luis de Bethencourt <luis@debethencourt.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: speakup: replace simple_strtoul() with kstrtoint()
Date	2015-06-24 01:20 +0200
Message-ID	<pEFDY-sP-7@gated-at.bofh.it> (permalink)
References	<pEDiO-5io-5@gated-at.bofh.it> <pEFkC-8ie-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 24, 2015 at 01:53:33AM +0300, Dan Carpenter wrote:
> Nope.  Your patch is totally wrong (buggy).  Please be more careful in
> the future.
> 
> regards,
> dan carpenter
> 

I saw other commits replace the obsolete simple_strtoul() this way and the
documentation makes it look like it is a 1 to 1 replacement.

Sorry about this. I will investigate further to understand why this is buggy
and be more careful in the future.

Thanks for the review,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: speakup: replace simple_strtoul() with  kstrtoint() Luis de Bethencourt <luis@debethencourt.com> - 2015-06-24 01:20 +0200
  Re: [PATCH] staging: speakup: replace simple_strtoul() with  kstrtoint() Dan Carpenter <dan.carpenter@oracle.com> - 2015-06-25 10:30 +0200

csiph-web