Re: [PATCH] staging: comedi: don't split Author string

From	Ian Abbott <abbotti@mev.co.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: comedi: don't split Author string
Date	2015-06-22 13:50 +0200
Message-ID	<pE8oF-2AP-3@gated-at.bofh.it> (permalink)
References	<pDxp7-eo-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 20/06/15 21:14, Luis de Bethencourt wrote:
> fixes checkpatch.pl WARNING: quoted string split across lines
>
> +MODULE_AUTHOR("David A. Schleef <ds@schleef.org>, "
> +             "Frank Mori Hess <fmhess@users.sourceforge.net>");
>
> total: 0 errors, 1 warnings, 114 lines checked
>
> Modules with multiple authors have a MODULE_AUTHOR line for each one.
>
> Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> ---
>   drivers/staging/comedi/drivers/das08_cs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/das08_cs.c b/drivers/staging/comedi/drivers/das08_cs.c
> index 93fab68..9c02b17 100644
> --- a/drivers/staging/comedi/drivers/das08_cs.c
> +++ b/drivers/staging/comedi/drivers/das08_cs.c
> @@ -108,7 +108,7 @@ static struct pcmcia_driver das08_cs_driver = {
>   };
>   module_comedi_pcmcia_driver(driver_das08_cs, das08_cs_driver);
>
> -MODULE_AUTHOR("David A. Schleef <ds@schleef.org>, "
> -	      "Frank Mori Hess <fmhess@users.sourceforge.net>");
> +MODULE_AUTHOR("David A. Schleef <ds@schleef.org>");
> +MODULE_AUTHOR("Frank Mori Hess <fmhess@users.sourceforge.net>");
>   MODULE_DESCRIPTION("Comedi driver for ComputerBoards DAS-08 PCMCIA boards");
>   MODULE_LICENSE("GPL");
>

Okay, it would be nice if the patch subject line mentioned the name of 
the module, but this is the only one in COMEDI with a split author line.

Reviewed-by: Ian Abbott <abbotti@mev.co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] staging: comedi: don't split Author string Ian Abbott <abbotti@mev.co.uk> - 2015-06-22 13:50 +0200

csiph-web