Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168614

Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod

Show all headers | View raw

On Fri, Jun 19, 2015 at 5:14 PM, Charles Keepax
<ckeepax@opensource.wolfsonmicro.com> wrote:
> On Fri, Jun 19, 2015 at 11:36:47AM +0900, Chanwoo Choi wrote:
>> Hi Charles,
>>
>> On Thu, Jun 18, 2015 at 11:43 PM, Charles Keepax
>> <ckeepax@opensource.wolfsonmicro.com> wrote:
>> > Convert to using the newer gpiod interface for the micd_pol_gpio.
>> > Although we still carry support for the old gpio interface from pdata.
>> >
>> > Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
>> > ---
>> > +                       mode = GPIOD_OUT_HIGH;
>> > +               else
>> > +                       mode = GPIOD_OUT_LOW;
>> > +
>> > +               info->micd_pol_gpio = gpiod_get_optional(arizona->dev,
>> > +                                                        "wlf,micd-pol",
>> > +                                                        GPIOD_OUT_LOW);
>>
>> You can use the devm_gpiod_get_optional() to manage the system
>> resource automatically.
>>
>
> We can't actually use the devm call here, we need to pass
> arizona->dev as that is where the DT will reside, which is the
> device for the MFD. But if the devm is attached to the device for
> the MFD then it will not clear up when the extcon driver is
> unloaded. As such we have to do the put manually.
>
> I will look at respinning for the other comments.

I don't understand. extcon-arizona.c used already following devm_* functions:
- devm_kzalloc()
- devm_regulator_get()
- devm_extcon_dev_*()
- devm_input_allocate_device()
- devm_gpio_request_one()

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 10:20 +0200
  Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Chanwoo Choi <cwchoi00@gmail.com> - 2015-06-19 10:40 +0200
    Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 11:20 +0200
      Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Chanwoo Choi <cwchoi00@gmail.com> - 2015-06-19 12:00 +0200
        Re: [PATCH v2 3/5] extcon: arizona: Convert to gpiod Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-06-19 12:00 +0200

csiph-web