Re: [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy()

From	David Rientjes <rientjes@google.com>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in dma_pool_destroy()
Date	2015-06-18 01:30 +0200
Message-ID	<pCuWo-7JA-41@gated-at.bofh.it> (permalink)
References	<pzqvT-682-7@gated-at.bofh.it> <pzqvT-682-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 9 Jun 2015, Sergey Senozhatsky wrote:

> dma_pool_destroy() does not tolerate a NULL dma_pool pointer
> argument and performs a NULL-pointer dereference. This requires
> additional attention and effort from developers/reviewers and
> forces all dma_pool_destroy() callers to do a NULL check
> 
> 	if (pool)
> 		dma_pool_destroy(pool);
> 
> Or, otherwise, be invalid dma_pool_destroy() users.
> 
> Tweak dma_pool_destroy() and NULL-check the pointer there.
> 
> Proposed by Andrew Morton.
> 
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Reported-by: Andrew Morton <akpm@linux-foundation.org>
> LKML-reference: https://lkml.org/lkml/2015/6/8/583

Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC][PATCH 3/5] mm/dmapool: allow NULL `pool' pointer in  dma_pool_destroy() David Rientjes <rientjes@google.com> - 2015-06-18 01:30 +0200

csiph-web