Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1163601

diffs in changelogs

Show all headers | View raw

People often put diff snippets in changelogs.  This causes problems
when one tries to apply a file containing both the changelog and the
diff because patch(1) tries to apply the diff which it found in the
changelog.

eg, something like

	git show d24a6e1087030b6da | patch -p1

will go haywire.

So can we please have a checkpatch test warning people away from doing
this?


patch(1) seems to be really promiscuous in its detection of a patch.  I
haven't had much success searching for "^--- " and similar.  What works
best for me is searching for "^[whitespace]@@ -".

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

diffs in changelogs Andrew Morton <akpm@linux-foundation.org> - 2015-06-11 22:50 +0200
  Re: diffs in changelogs Joe Perches <joe@perches.com> - 2015-06-12 05:20 +0200
    Re: diffs in changelogs Andrew Morton <akpm@linux-foundation.org> - 2015-06-12 05:20 +0200
      Re: diffs in changelogs Joe Perches <joe@perches.com> - 2015-06-12 06:00 +0200

csiph-web