Programming Style

From	rickman <gnuarm@gmail.com>
Newsgroups	comp.lang.forth
Subject	Programming Style
Date	2016-10-27 13:01 -0400
Organization	A noiseless patient Spider
Message-ID	<nutbsn$k0a$1@dont-email.me> (permalink)

Show all headers | View raw

As I am sure many here know I am only an occasional user of Forth.  I 
mostly use it to write test code for my hardware projects.  I don't 
deliver code to my customers so I am free to use any language I wish.

I find my coding style is heavily influenced by my heavy use of VHDL. 
Forth and VHDL are diametrically opposed in philosophies I think.  So 
I'm curious if my style is what other Forth programmers would use.

I do try to keep my definitions small, but I am not crazy about a huge 
proliferation of words.  Here is an example of one I am writing now.  I 
think it works, but am not able to test it from lack of hardware, so 
there may be bugs.  I'm just curious what people think of this style.


\ format and send write command with u1 as data and u2 as address, 
return error flag
\ TRUE is passed, FALSE is error
: WriteCmd ( u1 u2 -- flag )
     HEX OVER SWAP [char] W FormatCmd2
     DisplayComFlush ComSendStr ComReadEcho
     9 ScanReply <> IF THROW_COMM_WRITE_VERIFY THROW THEN
     TRUE DECIMAL ;


: ReadCmd ( u1 -- u2 ) \ format and send read command with u1 as address
     HEX DUP ReadCmdFmt
     ReadCmdSend
     OVER = IF DROP ELSE ReadVerErr THEN
     6 ScanReply
     DECIMAL
     ;

: VerReadLoop ( reg, n, sel -- )
     SelectCmd 0 DO I OVER WriteCmd DROP
         DUP ReadCmd 2DUP <> IF
             2DUP CR ."*** verify error *** read - " h.
             ."  : expected - " h. THEN
         DROP
     LOOP ;

The words ReadCmd sends a command to read hardware and gets a response 
which is left on the stack.  WriteCmd is similar, but verifies the 
command was received correctly and leaves a flag on the stack.

I'm not providing code for the lower words because they were written at 
a time when I didn't trust my system comms and added a *lot* of error 
checking code.  I found the problem in the hardware and some of the 
error checking got ripped out while other remains.  It is pretty 
inconsistent and ugly.  No time or need to fix it now as the test system 
is being used for the last time now.

-- 

Rick C

Back to comp.lang.forth | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Programming Style rickman <gnuarm@gmail.com> - 2016-10-27 13:01 -0400
  Re: Programming Style Howerd <howerdo@yahoo.co.uk> - 2016-10-27 12:42 -0700
    Re: Programming Style rickman <gnuarm@gmail.com> - 2016-10-29 17:35 -0400
      Re: Programming Style Howerd <howerdo@yahoo.co.uk> - 2016-11-01 02:05 -0700
        Re: Programming Style luser droog <mijoryx@yahoo.com> - 2016-11-02 06:23 -0700
          Re: Programming Style Howerd <howerdo@yahoo.co.uk> - 2016-11-02 09:15 -0700
          Re: Programming Style hughaguilar96@gmail.com - 2016-11-02 12:15 -0700
            Re: Programming Style Howerd <howerdo@yahoo.co.uk> - 2016-11-03 06:40 -0700
              Re: Programming Style alex <alex@rivadpm.com> - 2016-11-03 22:28 +0000
  Re: Programming Style anotherreepca@gmail.com - 2016-11-05 23:01 -0700
    Re: Programming Style Bernd Paysan <bernd@net2o.de> - 2016-11-27 00:18 +0000

csiph-web