Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.php > #8674

Re: question about class getters

Show all headers | View raw

On 3/15/2013 1:53 PM, David Heller wrote:
> On Mar 15, 1:11 pm, Jerry Stuckle <jstuck...@attglobal.net> wrote:
>> On 3/15/2013 11:42 AM, David Heller wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>> Hello
>>
>>> I have the following code snippet:
>>
>>> Class myClass
>>
>>> {
>>>    public function makeArray()
>>> {
>>> $this->my_array = array('Mon', 'Tues', 'Wed', 'Thurs', 'Friday',
>>> 'Sat', 'Sun');
>>> }
>>> pubic function getArray()
>>> {
>>>    return $this->my_array;
>>> }
>>> }
>>
>>> and then do the following
>>
>>> var $MyVar = new myClass();
>>> var $mydate = $MyVar->getArray[1];
>>> echo $mydate;
>>> => Mon
>>> will this work? If not how to make it work?
>>
>>> Thanks,
>>
>>> Dave
>>
>> Not quite, for a couple of reasons.  As Salvatore pointed out,
>> getArray() is a function, not a variable, so you need to code it as a
>> function.  The other problem is you never called makeArray() and don't
>> have a constructor, so $my_array doesn't exist (also it should be
>> declared as a class variable).
>>
>> Something like this should works:
>>
>> class MyClass {
>>     private $my_array;
>>
>>     public function __construct() { // Constructor
>>       $this->my_array = array('Mon', 'Tues', 'Wed', 'Thurs', 'Friday',
>>         'Sat', 'Sun');
>>     }
>>     public function getArray($i) {
>>       if ($i >= 0 && $i < count($this->my_array))  // Verify index
>>         return $this->my_array[$i];
>>       else
>>         return null;  // Out of range
>>     }
>>
>> }
>>
>> $myVar = new MyClass();
>> $mydate = $myVar->getArray(1); // Pass index as an argument
>> echo $mydate;
>>
>> => Tues
>>
>> (PHP array indexes start with zero, not one).
>>
>> --
>> ==================
>> Remove the "x" from my email address
>> Jerry Stuckle
>> JDS Computer Training Corp.
>> jstuck...@attglobal.net
>> ==================
>
> Even better:
>
> class MyClass {
>      private $my_array;
>
>      public function __construct() { // Constructor
>        $this->my_array = array('Mon', 'Tues', 'Wed', 'Thurs', 'Friday',
>          'Sat', 'Sun');
>      }
>      public function __get($i) {
>        // if ($i >= 0 && $i < count($this->my_array))  // Verify index
>        if(array_key_exists($i, $this->my_array)){         // For keys
> that are non-numerical
>    return $this->my_array[$i];}
>        else
>          return null;  // Out of range or non-existant
>      }
>
>   }
>
> I get it now (no pun intended).
>
> Dave
>

No, __get is a "magic method" and used to access properties for which 
you have no special getter method.  You need to pass the name of the 
property you wish.  It really doesn't conform to OO standards, and as 
your object complexity increases, the complexity of your magic methods 
increases.  It's also not applicable to passing additional parameters, 
such as the index you wish.

I really prefer to use individual getter and setter methods for object 
properties, as is indicated in OO principles.

-- 
==================
Remove the "x" from my email address
Jerry Stuckle
JDS Computer Training Corp.
jstucklex@attglobal.net
==================

Back to comp.lang.php | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

question about class getters David Heller <daveh@allheller.net> - 2013-03-15 08:42 -0700
  Re: question about class getters Salvatore <sal@yojimbo.hack.invalid> - 2013-03-15 16:12 +0000
    Re: question about class getters David Heller <daveh@allheller.net> - 2013-03-15 09:48 -0700
      Re: question about class getters "M. Strobel" <sorry_no_mail_here@nowhere.dee> - 2013-03-16 12:06 +0100
  Re: question about class getters Jerry Stuckle <jstucklex@attglobal.net> - 2013-03-15 13:11 -0400
    Re: question about class getters David Heller <daveh@allheller.net> - 2013-03-15 10:53 -0700
      Re: question about class getters Jerry Stuckle <jstucklex@attglobal.net> - 2013-03-15 14:56 -0400
        Re: question about class getters Curtis Dyer <dyer85@gmail.com> - 2013-03-21 09:31 +0000
          Re: question about class getters Jerry Stuckle <jstucklex@attglobal.net> - 2013-03-21 08:55 -0400
            Re: question about class getters Christoph Becker <cmbecker69@gmx.de> - 2013-03-21 14:12 +0100
            Re: question about class getters Curtis Dyer <dyer85@gmail.com> - 2013-03-23 07:14 +0000
              Re: question about class getters Jerry Stuckle <jstucklex@attglobal.net> - 2013-03-23 08:46 -0400

csiph-web