Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.php > #18778

Re: Help With Warning Message

From "J.O. Aho" <user@example.net>
Newsgroups comp.lang.php
Subject Re: Help With Warning Message
Date 2021-08-24 00:33 +0200
Message-ID <ioim27F5698U1@mid.individual.net> (permalink)
References <7no5igtt055jqdalqa2u2vlkfeu6bvhnag@4ax.com> <sfuut5$lb8$1@dont-email.me> <8ia6ig94heh1gjujblafvn17or10ufdlik@4ax.com> <ioh040Fpg0kU1@mid.individual.net> <sg0oqs$g6i$1@dont-email.me>

Show all headers | View raw


On 23/08/2021 20.19, Lew Pitcher wrote:

> And, to be complete, the OP should check the value in $result4
> before invoking the fetch() method. So the logic fragment should
> look more like
>    $result4 = $dbh->query($query4);
>    if ($result4 === FALSE)
>    {
>      /* query() failed for some reason - abort this activity */
>    }
>    else
>    {
>      $da = $result4->FETCH(PDO::FETCH_ASSOC);
>      if ($da === FALSE)
>      {
>        /* fetch() failed for some reason - abort this activity */
>      }
>      else $da_name = $da['airport_name'];
>    }
> 
Make the code even better (and more readable), we should skip the else-part

    $result4 = $dbh->query($query4);
    if ($result4 === FALSE)
    {
      throw new Exception("Query failed: " + $dbh->errorInfo()[2]);
    }

    $da = $result4->FETCH(PDO::FETCH_ASSOC);
    if ($da === FALSE)
    {
        throw new Exception("Fetch failed.");
    }

    $da_name = $da['airport_name'];


Of course this requires you take care of the exception higher up in the 
code and give a nice general error message, log the exception.

-- 

  //Aho

Back to comp.lang.php | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Help With Warning Message Call Me Tom <noemail@noemail.com> - 2021-08-22 20:00 -0400
  Re: Help With Warning Message Lew Pitcher <lew.pitcher@digitalfreehold.ca> - 2021-08-23 01:50 +0000
    Re: Help With Warning Message Call Me Tom <noemail@noemail.com> - 2021-08-23 01:03 -0400
      Re: Help With Warning Message "J.O. Aho" <user@example.net> - 2021-08-23 09:13 +0200
        Re: Help With Warning Message Lew Pitcher <lew.pitcher@digitalfreehold.ca> - 2021-08-23 18:19 +0000
          Re: Help With Warning Message Call Me Tom <noemail@noemail.com> - 2021-08-23 15:26 -0400
          Re: Help With Warning Message "J.O. Aho" <user@example.net> - 2021-08-24 00:33 +0200
      Re: Help With Warning Message Lew Pitcher <lew.pitcher@digitalfreehold.ca> - 2021-08-23 11:47 +0000
  Re: Help With Warning Message Arno Welzel <usenet@arnowelzel.de> - 2021-08-30 10:21 +0200

csiph-web