Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #60375

Re: Please critique my strdupf library

Show all headers | View raw

samuelallenalexander@gmail.com wrote:
> On Sunday, April 19, 2015 at 9:46:39 AM UTC+1, Ian Collins wrote:
>> samuel wrote:
>>> Dear comp.lang.c,
>>>
>>> I wrote a tiny little library to implement "strdupf", now I don't know how I ever lived without it.  strdupf is like strdup, except it takes printf-style variadic format arguments instead of a single string argument.
>>>
>>> The library is here: https://github.com/semitrivial/mallocf
>>>
>>> Please critique the library, in particular I'm concerned about:
>>>
>>> * Portability: Have I accidentally relied on anything implementation-dependent?
>>>
>>> * Correctness: Have I committed any glaring sins against C?
>>>
>>> * Style: Aside from my signature 2-space indents, have I committed any stylistic sins?
>>>
>>> Is there anything you can see that would further improve the library?
>>
>> What is the reason for the macros at the top of mallocf.c?  va_copy and
>> va_end are standard.
>>
>
>  From my literature review, I got the impression va_copy is rather finicky on pre-C99, see the bottom section here:
> http://www.gnu.org/software/libc/manual/html_node/Argument-Macros.html
>
> I guess I should mention that in a comment, thank you for the pointer.

Well I was using them in the mid 80's, so I guess there might be really 
old compilers that don't have them.  I wouldn't bother looking back that 
far!

-- 
Ian Collins

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 01:34 -0700
  Re: Please critique my strdupf library Ian Collins <ian-news@hotmail.com> - 2015-04-19 20:46 +1200
    Re: Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 02:25 -0700
      Re: Please critique my strdupf library Ian Collins <ian-news@hotmail.com> - 2015-04-19 21:35 +1200
        Re: Please critique my strdupf library Keith Thompson <kst-u@mib.org> - 2015-04-19 07:44 -0700
          Re: Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 10:23 -0700
            Re: Please critique my strdupf library Morris Dovey <mrdovey@iedu.com> - 2015-04-19 13:09 -0500
      Re: Please critique my strdupf library fir <profesor.fir@gmail.com> - 2015-04-19 02:48 -0700
        Re: Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 03:42 -0700
  Re: Please critique my strdupf library fir <profesor.fir@gmail.com> - 2015-04-19 02:11 -0700
  Re: Please critique my strdupf library Ben Bacarisse <ben.usenet@bsb.me.uk> - 2015-04-19 11:11 +0100
    Re: Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 04:36 -0700
      Re: Please critique my strdupf library Johannes Bauer <dfnsonfsduifb@gmx.de> - 2015-04-19 15:41 +0200
        Re: Please critique my strdupf library samuelallenalexander@gmail.com - 2015-04-19 07:28 -0700
  Re: Please critique my strdupf library August Karlstrom <fusionfile@gmail.com> - 2015-04-19 12:12 +0200
  Re: Please critique my strdupf library Johannes Bauer <dfnsonfsduifb@gmx.de> - 2015-04-19 13:25 +0200
    Re: Please critique my strdupf library Ben Bacarisse <ben.usenet@bsb.me.uk> - 2015-04-19 13:32 +0100
  Re: Please critique my strdupf library Lőrinczy Zsigmond <nospam@for.me> - 2015-04-19 16:29 +0200
  Re: Please critique my strdupf library Keith Thompson <kst-u@mib.org> - 2015-04-19 07:52 -0700

csiph-web