Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.c > #109655

Re: Printing like palindrome

Show all headers | View raw

On 09/05/2017 11:59, arnuld wrote:

>       if(!getFirstLetter(argv[1], &c)) printPalindrome(c);
>       else printf("You did not enter a character. Enter uppercase
> character \n");
>     }
>   return 0;
> }

I didn't look at the actual code too closely before. This looks untidy. 
It seems that getFirstLetter() returns a status 0 for success, and 1 for 
failure, with the letter itself via a pointer. But that's not so obvious 
from looking at this. It's also overkill.

I think better would be:

    if (c = getFirstLetter(argv[1]))
        printPalindrome(c);
    else
        ... deal with error...

With c == 0 signifying an error.

(And since the checking done by getFirstLetter is perfunctory, the 
following would do:

   c = *argv[1];

   if (c >= 'A' && c <= 'Z')       // or any of a million other ways
      printPalindrome(c);


Personally I would also arrange it to get the verification out of the 
way first, then I have my verified input c, and can do what I need to do 
with it without still being embroiled in user interface stuff.)

-- 
bartc

Back to comp.lang.c | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Printing like palindrome arnuld <sunrise@invalid.address> - 2017-05-09 10:59 +0000
  Re: Printing like palindrome Barry Schwarz <schwarzb@dqel.com> - 2017-05-09 04:26 -0700
    Re: Printing like palindrome Robert Wessel <robertwessel2@yahoo.com> - 2017-05-09 14:10 -0500
      Re: Printing like palindrome Keith Thompson <kst-u@mib.org> - 2017-05-09 12:33 -0700
        Re: Printing like palindrome Richard Heathfield <rjh@cpax.org.uk> - 2017-05-09 23:05 +0100
          Re: Printing like palindrome raltbos@xs4all.nl (Richard Bos) - 2017-05-10 10:25 +0000
            Re: Printing like palindrome Richard Heathfield <rjh@cpax.org.uk> - 2017-05-10 11:44 +0100
          Re: Printing like palindrome Keith Thompson <kst-u@mib.org> - 2017-05-10 09:48 -0700
            Re: Printing like palindrome Gareth Owen <gwowen@gmail.com> - 2017-05-10 18:59 +0100
        Re: Printing like palindrome arnuld <sunrise@invalid.address> - 2017-05-12 07:14 +0000
      Re: Printing like palindrome arnuld <sunrise@invalid.address> - 2017-05-12 07:44 +0000
    Re: Printing like palindrome arnuld <sunrise@invalid.address> - 2017-05-12 07:20 +0000
      Re: Printing like palindrome Keith Thompson <kst-u@mib.org> - 2017-05-12 08:49 -0700
        Re: Printing like palindrome arnuld <sunrise@invalid.address> - 2017-05-14 02:01 +0000
  Re: Printing like palindrome mark.bluemel@gmail.com - 2017-05-09 07:13 -0700
    Re: Printing like palindrome scott@slp53.sl.home (Scott Lurndal) - 2017-05-09 14:59 +0000
      Re: Printing like palindrome Keith Thompson <kst-u@mib.org> - 2017-05-09 08:27 -0700
      Re: Printing like palindrome Barry Schwarz <schwarzb@dqel.com> - 2017-05-09 10:40 -0700
  Re: Printing like palindrome scott@slp53.sl.home (Scott Lurndal) - 2017-05-09 14:38 +0000
    Re: Printing like palindrome Ben Bacarisse <ben.usenet@bsb.me.uk> - 2017-05-09 22:48 +0100
      Re: Printing like palindrome scott@slp53.sl.home (Scott Lurndal) - 2017-05-10 13:21 +0000
        Re: Printing like palindrome Ben Bacarisse <ben.usenet@bsb.me.uk> - 2017-05-10 15:45 +0100
        Re: Printing like palindrome Barry Schwarz <schwarzb@dqel.com> - 2017-05-10 10:26 -0700
  Re: Printing like palindrome bartc <bc@freeuk.com> - 2017-05-09 21:28 +0100
    Re: Printing like palindrome raltbos@xs4all.nl (Richard Bos) - 2017-05-10 10:27 +0000
    Re: Printing like palindrome Chad <cdalten@gmail.com> - 2017-05-10 10:39 -0700
  Re: Printing like palindrome bartc <bc@freeuk.com> - 2017-05-10 12:54 +0100
  Printing like palindrome asetofsymbols@gmail.com - 2017-05-12 02:32 -0700

csiph-web