Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1286069

Bug#1122181: Bug#1130447: Acknowledgement (devscripts: uscan - upgrade to devscripts to 2.26.x breaks versionmangle)

Show all headers | View raw

El dom, 15 mar 2026 a las 0:26, Thomas Dickey
(<dickey@invisible-island.net>) escribió:
>
> On Sat, Mar 14, 2026 at 08:07:52PM +0100, Agustin Martin wrote:
> > On Thu, 12 Mar 2026 10:04:45 -0400 Thomas Dickey
> > <dickey@invisible-island.net> wrote:
> > > Revisiting #1122181, I see that its proposed patch fixes the issue which
> > > I reported in #1130447.
> >
> >
> > I am not one of uscan maintainers nor know about its internals, but
> > thanks a lot for all the detailed analysis. By the way, this seems to
> > be the same problem as #1112388. Cc'ing.
> >
> > The problem with the patch proposed by Uwe is that on package build it
> > breaks one test (with 6 ASSERT error messages)
> > Change you propose causes even more ASSERT lines (34).
>
> I realized that Uwe's patch was an improvement
> (which is why I said I'd close #1130447 -- actually on
> that, I saw the progress on #1122181 made it too late for
> me to suggest merging).

HI,

I would call them different approaches. Something may trigger more
error messages on build but be closer to the actual problem, and all
reasonable info is good (and your mails contain a lot of good info).

One minor addition. Tried with

--- a/lib/Devscripts/Uscan/Modes/Http.pm
+++ b/lib/Devscripts/Uscan/Modes/Http.pm
@@ -465,7 +465,7 @@ sub parse_href {
     }
     $match = '';
     if (defined $self->shared->{download_version}) {
-        if ($version eq $self->shared->{download_version}) {
+        if ($mangled_version eq $self->shared->{download_version}) {
             $match = "matched with the download version";
         }
     }

On build I get the same errors as with Uwe's patch.

Regarding the three bug reports I would merge all them.

-- 
Agustin

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#1122181: Bug#1130447: Acknowledgement (devscripts: uscan - upgrade to devscripts to 2.26.x breaks versionmangle) Agustin Martin <agmartin@debian.org> - 2026-03-14 20:10 +0100
  Bug#1122181: Bug#1130447: Acknowledgement (devscripts: uscan - upgrade to devscripts to 2.26.x breaks versionmangle) Thomas Dickey <dickey@invisible-island.net> - 2026-03-15 00:30 +0100
    Bug#1122181: Bug#1130447: Acknowledgement (devscripts: uscan - upgrade to devscripts to 2.26.x breaks versionmangle) Agustin Martin <agmartin@debian.org> - 2026-03-15 12:00 +0100
      Bug#1112388: Bug#1130447: Acknowledgement (devscripts: uscan - upgrade to devscripts to 2.26.x breaks versionmangle) Agustin Martin <agmartin@debian.org> - 2026-03-18 00:20 +0100

csiph-web