Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1282324

Bug#1124124: Debian NEW review of golang-filippo-nistec 0.0.4-2: REJECTED

From Simon Josefsson <simon@josefsson.org>
Newsgroups linux.debian.bugs.dist
Subject Bug#1124124: Debian NEW review of golang-filippo-nistec 0.0.4-2: REJECTED
Date 2026-02-15 22:10 +0100
Message-ID <MoRxn-RwO-11@gated-at.bofh.it> (permalink)
References <MoRxn-RwO-13@gated-at.bofh.it> <M6YQF-6izc-1@gated-at.bofh.it> <MoRxn-RwO-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Good catch, thank you!  I applied this and made another NEW upload:

https://salsa.debian.org/go-team/packages/golang-filippo-nistec/-/commit/f8150468ad145836b0561819675f89f37120de99

/Simon

siretart@debian.org writes:

> The Debian NEW review of golang-filippo-nistec 0.0.4-2 has been completed.
>
> Decision: REJECTED
> Reviewer: Reinhard Tartler
>
> Review comment:
>
> Inaccurate `debian/copyright` for `internal/fiat`: The
> `debian/copyright` file lists `internal/fiat/*` as being under the
> BSD-1-Clause license with "The fiat-crypto Authors" as copyright
> holders. However, several files in this directory (e.g.,
> internal/fiat/p256.go, internal/fiat/p224.go,
> internal/fiat/generate.go, and the *_invert.go files) contain headers
> explicitly stating:
>
>    // Copyright 2021 The Go Authors. All rights reserved.
>    // Use of this source code is governed by a BSD-style
>    // license that can be found in the LICENSE file.
>
> These copyright statements must be preserved.
>
> Only the *_fiat64.go files and the README appear to be under the
> fiat-crypto BSD-1-Clause license.
>
> Please update debian/copyright to include all copyright statements
>
> Full review details:
> https://dfsg-new-queue.debian.org/reviews/golang-filippo-nistec

Back to linux.debian.bugs.dist | Previous | Next | Find similar | Unroll thread


Thread

Bug#1124124: Debian NEW review of golang-filippo-nistec 0.0.4-2: REJECTED Simon Josefsson <simon@josefsson.org> - 2026-02-15 22:10 +0100

csiph-web