Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.devel.mentors > #48103

Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities

Show all headers | View raw

Control: tags -1 moreinfo

Hi Martin,

a quick review, a few changes would be appreciated, e.g the changelog
thing-

On Mon, Nov 17, 2025 at 07:28:10AM +0000, Martin Kepplinger wrote:
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "tslib":
> 
>  * Package name     : tslib
>    Version          : 1.24-1
>    Upstream contact : tslib@lists.infradead.org
>  * URL              : http://tslib.org
>  * License          : LGPL-2+, GPL-2+
>  * Vcs              : https://github.com/merge/tslib-debian
>    Section          : embedded
> 
> 
> Changes since the last upload:
> 
>  tslib (1.24-1) unstable; urgency=low
>  .
>    * Update to tslib version 1.24
>    * debiann/rules: add empty dh_missing override
>    * debian: remove compat file and move to control
>    * debian/compat: update to v13
> 
> Regards,
> 
> -- 
>   Martin Kepplinger-Novakovic

- d/changelog:
  - Version 1.23-1 has never been in Debian. Please merge the relevant
    entries to 1.24-1 OR mark 1.23-1 UNRELEASED.
  - SV-Bump to 4.7.2 has not been documented. Did you need to change
    anything?
  ( - d/changelog seems to focus on "what" has changed, not "why". The
  what is usually clear when looking at the diff, but not the "why". This
  makes reviewing harder.)

- d/rules: 
  - all those DEB_*_MAINT_* shouldn't be needed anymore, check if they
    can be removed; -O2 should never be set in d/rules, this break eg
    DEB_BUILD_OPTIONS=noopt, 
  - why do you overrule_dh_missing? Guessing that you might have files
    not installed, they would go to d/not-installed.

- d/copyright
  - the year of your contributions could be updated.

- d/*.install
  - instead of usr/lib/*/ you could write usr/lib/${DEB_HOST_MULTIARCH}/

-- 
Cheers,
tobi

Back to linux.debian.devel.mentors | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Martin Kepplinger <martink@posteo.de> - 2025-11-17 08:40 +0100
  Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Tobias Frost <tobi@debian.org> - 2025-11-17 18:50 +0100
  Bug#1120830: RFS: tslib/1.24-1 [ITA] -- touch screen library utilities Martin Kepplinger <martink@posteo.de> - 2025-11-25 08:10 +0100

csiph-web