Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1243121

Bug#1103503: isc-dhcp-client: In /etc/apparmor.d/local, sbin.dhclient should be renamed to usr.sbin.dhclient for consistency

Show all headers | View raw

Hi,

On 2025-04-22 11:52:24 +0200, intrigeri wrote:
> Vincent Lefevre (2025-04-19):
> > On 2025-04-18 13:40:01 +0200, intrigeri wrote:
> >> What dhclient files have been removed before the upgrade?
> >
> > /etc/apparmor.d/sbin.dhclient
> > /etc/apparmor.d/local/sbin.dhclient
> >
> >> How were they removed?
> >
> > With "rm".
> 
> OK, then FWIW I don't think severity serious is justified: you've
> manually deleted a file (/etc/apparmor.d/local/sbin.dhclient) created
> by maintainer scripts. I'm not the maintainer so this is just my
> personal opinion.

I disagree. It is the right of the user to remove configuration files,
as long as this is done in a consistent way. Packages must be able to
cope with that (re-adding the main file but not the associated local
one is not correct).

> >> Can you please describe how the resulting configuration is broken?
> >
> > After the upgrade, I just have
> >
> > cventin:~> ll /etc/apparmor.d/**/*dhclient*
> > -rw-r--r-- 1 root root 3590 2025-04-04 16:49:15 /etc/apparmor.d/usr.sbin.dhclient
> >
> > The one under /etc/apparmor.d/local is absent, though
> > /etc/apparmor.d/usr.sbin.dhclient does
> >
> >   #include <local/sbin.dhclient>
> 
> I think the maintainers will want to know what's the actual impact
> of this.
> 
> I suppose it makes apparmor.service fail to start?

No, I don't see any error with apparmor.service (and the documentation
does not suggest that there would be a fatal error for that).

> Anything else?

The apparmor.d(5) man page says:

  The  leading  '#'  is  optional,  and  the  '#include' keyword can be
  followed by an option conditional 'if exists' that specifies  profile
  compilation should continue if the specified file or directory is not
  found.

So, a missing file without "if exists" would stop the compilation of
the profile. I don't know what this implies in practice.

-- 
Vincent Lefèvre <vincent@vinc17.net> - Web: <https://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <https://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / Pascaline project (LIP, ENS-Lyon)

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#1103503: isc-dhcp-client: In /etc/apparmor.d/local, sbin.dhclient should be renamed to usr.sbin.dhclient for consistency Vincent Lefevre <vincent@vinc17.net> - 2025-04-18 11:20 +0200
  Bug#1103503: isc-dhcp-client: In /etc/apparmor.d/local, sbin.dhclient should be renamed to usr.sbin.dhclient for consistency Vincent Lefevre <vincent@vinc17.net> - 2025-04-18 11:40 +0200
  Bug#1103503: isc-dhcp-client: In /etc/apparmor.d/local, sbin.dhclient should be renamed to usr.sbin.dhclient for consistency Vincent Lefevre <vincent@vinc17.net> - 2025-04-22 13:10 +0200
  Bug#1103503: isc-dhcp-client: In /etc/apparmor.d/local, sbin.dhclient should be renamed to usr.sbin.dhclient for consistency Alexander Kurtz <alexander@kurtz.be> - 2025-05-03 20:40 +0200

csiph-web