Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG

From	Santiago Vila <sanvila@debian.org>
Newsgroups	linux.debian.bugs.rc
Subject	Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG
Date	2024-10-01 03:40 +0200
Message-ID	<JsA1P-g5j5-3@gated-at.bofh.it> (permalink)
References	(5 earlier) <Jso0F-fUMq-1@gated-at.bofh.it> <Jsp6p-fVH9-7@gated-at.bofh.it> <Jspzr-fWcW-1@gated-at.bofh.it> <JqhPI-eyyA-19@gated-at.bofh.it> <Jspzr-fWcW-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi. To test, I simplified the line in the Makefile to this:

deutex -h | grep -qw PNG

This should have the same effect but without the explanatory error message,
i.e. if it fails, make will stop.

The build log for a failed build looks like this:

deutex -h | grep -qw PNG
make -C lumps/dehacked # graphics/text depends on generated dehacked files
make[3]: Entering directory '/<<PKGBUILDDIR>>/lumps/dehacked'
../../scripts/simplecpp -DFREEDM < dehacked.txt > ../fdm_deh.lmp
make[2]: *** [Makefile:56: deutex-check] Error 141
make[2]: *** Waiting for unfinished jobs....

I searched for error 141 and found this:

https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q

So, the error in freedoom seems to happen because of two things:

a) using grep -q
b) The SHELL="bash -Eeuo pipefail" definition in debian/rules.

I don't know what would be the best way to fix this.

Maybe we could just take for granted that deutex has PNG support,
because it has, and drop the check in the toplevel Makefile,
as in the attached patch.

(I withdraw my suggestion to use --no-parallel).

Thanks.

Thread

Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG Simon McVittie <smcv@debian.org> - 2024-09-30 12:50 +0200
  Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG Santiago Vila <sanvila@debian.org> - 2024-09-30 13:10 +0200
    Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG Fabian Greffrath <fabian@greffrath.com> - 2024-09-30 16:00 +0200
      Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG Santiago Vila <sanvila@debian.org> - 2024-10-01 03:40 +0200
        Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG Fabian Greffrath <fabian@greffrath.com> - 2024-10-01 07:50 +0200

csiph-web