Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1200553

Bug#993308: firefox-esr: You might need to add a libpci3 dependency to ESR 91

Show all headers | View raw

Adding some context:

The function which throws the warning is here:
https://searchfox.org/mozilla-central/source/toolkit/xre/glxtest/glxtest.cpp#192

RHEL added libpci as dependency: 
https://bugzilla.redhat.com/show_bug.cgi?id=1955338

It was reported on BSD derivatives and Solaris, where libpci as well as 
the used sysfs nodes do not exist, hence for those, the function is now 
a dummy (see code):
- https://bugzilla.mozilla.org/show_bug.cgi?id=1868782
- https://misc.openbsd.narkive.com/XtvqpVLc/firefox-glxteset-libpci-missing

All the function does is storing PCI_VENDOR_ID and PCI_DEVICE_ID for the 
GPU.

I could find them being used only here:
https://searchfox.org/mozilla-central/source/widget/gtk/GfxInfo.cpp#209
And there are fallback mechanisms to derive those IDs.

Checking the linked bug report in the comments of this function and the 
top of glxtest.cpp: https://bugzilla.mozilla.org/show_bug.cgi?id=639842
So glxtest.cpp is only used to derive info for the Graphics section of 
about:support in X11 environments, and GfxInfo.cpp is used to generate 
this section.

I did a quick test on VM with X11 and Mesa drivers, and despite the fact 
that this warning is thrown, the Graphics section is identical with and 
without libpci, especially the "GPU #1" section does contain vendor and 
device ID and names in both cases, so the fallback mechanisms work. Only 
the end of the Graphics section contains and additional "Failure Log" 
entry, showing "glxtest: libpci missing" as well.

So libpci3 it is definitely not suites as dependency, IMO not as 
recommendation either, probably not even a suggestion. I would remove 
the startup warning, show it on about:support only, and extend the 
warning's text, stating that GPU vendor and device info may be 
inaccurate or missing. Not sure whether its worth a patch and upstream 
suggestion. I am no fans of pointless log entries above debug severity. 
Currently, some users/admins are wasting time to hunt down this warning 
when they face true issues with hardware acceleration or similar. And 
they may waste resources (marginal only, but in principle) installing 
the package, while it won't make any practical difference for hardware 
acceleration, or other issues they may experience.

Best regards,

Micha

Back to linux.debian.bugs.dist | Previous | Next | Find similar | Unroll thread

Thread

Bug#993308: firefox-esr: You might need to add a libpci3 dependency to ESR 91 MichaIng <micha@dietpi.com> - 2024-06-11 16:00 +0200

csiph-web