Re: Please test apt-listchanges 4.0 in experimental

From	Alexandre Detiste <alexandre.detiste@gmail.com>
Newsgroups	linux.debian.devel
Subject	Re: Please test apt-listchanges 4.0 in experimental
Date	2023-10-11 21:40 +0200
Message-ID	<HnNdL-fa0L-1@gated-at.bofh.it> (permalink)
References	<HmDTb-epD5-5@gated-at.bofh.it> <HnBZ0-f2MO-11@gated-at.bofh.it> <HnGYF-f6fW-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Le mer. 11 oct. 2023 à 14:54, Jonathan Kamens <jik@kamens.us> a écrit :
> Can you confirm that this occurred with 4.0 rather than 4.1?
I'm a bit messy & forgetful these times.
But you have #1053812 against 4.1 already.

> > Can annotations/mypy testing be considered now "best practices" for
> > Debian native packages ?
>
> Best practice? Sure. Requirement? Not so much.

Of course it's not a requirement;
and it can be done iteratively.


> Regarding apt-listchanges in particular, I have already spent countless hours getting
> ready for this new release, including the addition of a substantial unit-test suite
> where there were no tests before.

I see it, and it's nice work.

> I do not have the bandwidth to add type hints as well,
> and I do not think this should be a blocker to releasing the new version to the public.

This is why I propose to do it.

> I am happy to consider a MR if someone else wants to add typing to the code-base.

There's a first MR pending.

There's another one against python3-debconf with 100% "mypy --strict" coverage.

I just don't  know how to handle the "py.typed" there: it's a flag
file, contents doesn't matter.
It could be a "touch" in debian/rules, I just don't know what is the
prefered way.

Greetings

Back to linux.debian.devel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Please test apt-listchanges 4.0 in experimental Jonathan Kamens <jik@kamens.us> - 2023-10-08 17:30 +0200
  Re: Please test apt-listchanges 4.0 in experimental Jonathan Kamens <jik@kamens.us> - 2023-10-10 15:50 +0200
  Re: Please test apt-listchanges 4.0 in experimental Alexandre Detiste <alexandre.detiste@gmail.com> - 2023-10-11 09:40 +0200
    Re: Please test apt-listchanges 4.0 in experimental Jonathan Kamens <jik@kamens.us> - 2023-10-11 15:00 +0200
      Re: Please test apt-listchanges 4.0 in experimental Alexandre Detiste <alexandre.detiste@gmail.com> - 2023-10-11 21:40 +0200

csiph-web