Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.bugs.dist > #1102898

Bug#1010894: python-cheroot version number does not conform to PEP440

Show all headers | View raw

On 5/12/22 14:55, julien.puydt@gmail.com wrote:
> Hi,
> 
> Le jeudi 12 mai 2022 à 14:45 +0200, Heinrich Schuchardt a écrit :
>> Package: python-cheroot
>> Version: 8.6.0+ds1-2
>> Severity: normal
>>
>> Python package versions like 8.6.0+ds1 do not conform to PEP440. This
>> leads to errors in Ceph as reported in
>> https://bugs.launchpad.net/ubuntu/+source/ceph/+bug/1967139
>>
> 
> It's not a Python package version ; it's a Debian package version, so
> PEP440 doesn't apply.

Unfortunately this number is propagated into cheroot.__version__.

> 
>> Is this something to be corrected in this package?
>> Or is this a general problem with how we do Python packaging?
> 
> Let me ask bluntly: how is it a problem?

$ python3
 >>> import cheroot
 >>> print cheroot.__version__
8.6.0+ds1
 >>> from distutils.version import StrictVersion
 >>> StrictVersion(cheroot.__version__)
Traceback (most recent call last):
   File "<stdin>", line 1, in <module>
   File "/usr/lib/python3.10/distutils/version.py", line 40, in __init__
     self.parse(vstring)
   File "/usr/lib/python3.10/distutils/version.py", line 137, in parse
     raise ValueError("invalid version number '%s'" % vstring)
ValueError: invalid version number '8.6.0+ds1'
 >>>

> 
> If there were any issue with general Python packages versioning in
> Debian, perhaps you should contact the Debian Python Maintainers team?

You could patch this line to solve the problem:

cheroot/__init__.py:13:
__version__ = pkg_resources.get_distribution('cheroot').version

Best regards

Heinrich

> 
> Cheers,
> 
> J.Puydt

Back to linux.debian.bugs.dist | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Bug#1010894: python-cheroot version number does not conform to PEP440 Heinrich Schuchardt <heinrich.schuchardt@canonical.com> - 2022-05-12 14:50 +0200
  Bug#1010894: python-cheroot version number does not conform to PEP440 Heinrich Schuchardt <heinrich.schuchardt@canonical.com> - 2022-05-12 15:30 +0200
    Bug#1010894: python-cheroot version number does not conform to PEP440 julien.puydt@gmail.com - 2022-05-12 15:40 +0200
  Bug#1010894: python-cheroot version number does not conform to PEP440 julien.puydt@gmail.com - 2022-05-12 17:30 +0200
  Bug#1010894: python-cheroot version number does not conform to PEP440 julien.puydt@gmail.com - 2022-05-13 13:10 +0200

csiph-web