Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1102712

Bug#1010806: apt: Avoid color output on monochrome terminals

From Axel <axel.scheepers76+debian@gmail.com>
Newsgroups linux.debian.bugs.dist
Subject Bug#1010806: apt: Avoid color output on monochrome terminals
Date 2022-05-10 15:20 +0200
Message-ID <ElxWq-eycc-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Package: apt
Version: 2.2.4
Severity: normal

Dear Maintainer,

The apt command shows colors on monochrome terminals (even on a dumb terminal),
please avoid this. Included is a patch which i believe will solve the problem
and only allows output on terminals which actually have 'color' in them; the
same logic as to when to color the default bash prompt.
I have not tested this patch.

Kind regards,
Axel


--- private-output.cc.orig	2022-05-10 14:18:27.611767218 +0200
+++ private-output.cc	2022-05-10 14:20:17.511703336 +0200
@@ -86,7 +86,8 @@
       SigWinch(0);
    }
 
-   if(!isatty(1))
+   char *term = getenv("TERM");
+   if(!isatty(1) || strstr(term, "color") == NULL)
    {
       _config->Set("APT::Color", "false");
       _config->Set("APT::Color::Highlight", "");

Back to linux.debian.bugs.dist | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

Bug#1010806: apt: Avoid color output on monochrome terminals Axel <axel.scheepers76+debian@gmail.com> - 2022-05-10 15:20 +0200
  Bug#1010806: apt: Avoid color output on monochrome terminals Daniel Abrecht <debian-apt@danielabrecht.ch> - 2022-05-10 16:50 +0200
  Bug#1010806: apt: Avoid color output on monochrome terminals Adam Borowski <kilobyte@angband.pl> - 2022-05-10 17:00 +0200
    Bug#1010806: apt: Avoid color output on monochrome terminals Julian Andres Klode <jak@debian.org> - 2022-05-10 18:10 +0200
      Bug#1010806: apt: Avoid color output on monochrome terminals Axel Scheepers <axel.scheepers76@gmail.com> - 2022-05-10 21:00 +0200
        Bug#1010806: apt: Avoid color output on monochrome terminals Adam Borowski <kilobyte@angband.pl> - 2022-05-16 18:40 +0200
          Bug#1010806: apt: Avoid color output on monochrome terminals Axel Scheepers <axel.scheepers76@gmail.com> - 2022-05-16 20:20 +0200
            Bug#1010806: apt: Avoid color output on monochrome terminals Adam Borowski <kilobyte@angband.pl> - 2022-05-25 21:40 +0200
              Bug#1010806: apt: Avoid color output on monochrome terminals Axel Scheepers <axel.scheepers76@gmail.com> - 2022-05-26 11:10 +0200
          Bug#1010806: apt: Avoid color output on monochrome terminals Daniel Abrecht <debian-apt@danielabrecht.ch> - 2022-05-16 23:10 +0200
      Bug#1010806: apt: Avoid color output on monochrome terminals Axel Scheepers <axel.scheepers76@gmail.com> - 2022-05-10 21:50 +0200

csiph-web