Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.debian.bugs.dist > #1018376

Bug#965228: lighter FTBFS: narrowing conversions

From Helmut Grohne <helmut@subdivi.de>
Newsgroups linux.debian.bugs.dist
Subject Bug#965228: lighter FTBFS: narrowing conversions
Date 2020-07-17 22:50 +0200
Message-ID <AtFsR-DA-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Source: lighter
Version: 1.1.2-2
Severity: important
Tags: patch ftbfs

lighter fails to build from source, because:

main.cpp:26:25: error: narrowing conversion of ‘-1’ from ‘int’ to ‘char’ [-Wnarrowing]

What happens here is that nucToNum is assigned -1, but it is typed array
of char, which happens to be unsigned (on some architectures). It really
wants a small signed integer type here (representing numbers between -1
and 3). A very simple fix is using signed char (which isn't architecture
dependent). Please consider applying the attached patch.

Helmut

Back to linux.debian.bugs.dist | Previous | Next | Find similar | Unroll thread


Thread

Bug#965228: lighter FTBFS: narrowing conversions Helmut Grohne <helmut@subdivi.de> - 2020-07-17 22:50 +0200

csiph-web