Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.debian.project > #11868

Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer

Show all headers | View raw

Hi.

I've reviewed most of the spec you point to on salsa.

I think you might be getting some of the details before the basic
principles.

I agree with the principles you state, but would  probably state them
differently:
* Incremental review is valuable and is likely to improve our processes
* Minimizing duplicate review or unnecessary re-review is valuable
* getting reviewers the information they need so that they are not being
slowed down searching for it is valuable

* Better tooling can help with the above.

I tend to agree with all those principles and believe they are similar
in spirit to what you state.

Unfortunately, being a member of Debian, I find myself getting stuck in
the details and think you may have gotten a few things wrong.

* I think that reviewing a file every time the salt changes is too
  frequent.
  It is a sign that we might need to review, not that we certainly do.
  We don't tend to review files every time they change today, and I
  think pushing toward this would be problematic.

* Unfortunately the srcpkg-bool problem does not decompose into a set of
  file-bool problems the way you describe.
  The issue is license compatibility.
  Two licenses may be DFSG-free, but their combination may not be
  distributable (and thus not DFSG-free).



Next Steps

The biggest thing I see missing here is what are the next steps?
If we agree with your principles, what next?
How does this work go forward?

Back to linux.debian.project | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

libAWSL: Improving Human Efficiency for debian/copyright Reviewer Mo Zhou <lumin@debian.org> - 2020-05-23 15:10 +0200
  Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Olek Wojnar <olek@debian.org> - 2020-05-23 23:30 +0200
  Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Mo Zhou <lumin@debian.org> - 2020-05-24 09:10 +0200
  Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Sam Hartman <hartmans@debian.org> - 2020-05-26 14:20 +0200
    Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Michael Lustfield <michael@lustfield.net> - 2020-05-26 21:40 +0200
      Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Sam Hartman <hartmans@debian.org> - 2020-05-26 22:50 +0200
        Re: libAWSL: Improving Human Efficiency for debian/copyright Reviewer Mo Zhou <lumin@debian.org> - 2020-05-27 03:10 +0200

csiph-web